Merge pull request #23 from genme/fix-from-url

[LIBS-625] Fix missing filename in from_url request
uploadcare · Jul 10, 2023 · 6d70d47 · 6d70d47
2 parents d856e69 + cf4c00e
commit 6d70d47
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/internal/codec/codec.go b/internal/codec/codec.go
@@ -164,8 +164,7 @@ func writeFields(w *multipart.Writer, t reflect.Type, v reflect.Value) {
 		tf, vf := t.Field(i), v.Field(i)
 
 		// file has been already written
-		if tf.Name == config.FileFieldName ||
-			tf.Name == config.FilenameFieldName {
+		if tf.Name == config.FileFieldName {
 			continue
 		}
 

diff --git a/test/upload.go b/test/upload.go
@@ -52,7 +52,7 @@ func uploadFromURL(t *testing.T, r *testenv.Runner) {
 			t.Error(err)
 		}
 	}
-	assert.Equal(t, "photo_20190914_154427.jpg", info.OriginalFileName)
+	assert.Equal(t, "test_file_name", info.FileName)
 	r.Artifacts.Files = append(
 		r.Artifacts.Files,
 		&file.Info{BasicFileInfo: info.BasicFileInfo},
@@ -72,7 +72,7 @@ func uploadCreateGroup(t *testing.T, r *testenv.Runner) {
 	ctx := context.Background()
 	var ids []string
 	for _, r := range r.Artifacts.Files {
-		ids = append(ids, r.ID + "/-/resize/x10/")
+		ids = append(ids, r.ID+"/-/resize/x10/")
 	}
 	info, err := r.Upload.CreateGroup(ctx, ids)
 	assert.Equal(t, nil, err)