-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation update #139
Documentation update #139
Conversation
WalkthroughThe recent updates enhance the Uploadcare Android integration documentation by transitioning the build status badge from Travis CI to GitHub Actions, updating the supported Android SDK version to 34, and switching the repository reference from jCenter to Maven Central. Changes
Poem
Tip AI model upgrade
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- README.md (2 hunks)
- library/README.md (1 hunks)
- widget/README.md (1 hunks)
Additional context used
Markdownlint
widget/README.md
16-16: Expected: setext; Actual: atx
Heading style(MD003, heading-style)
library/README.md
21-21: Expected: setext; Actual: atx
Heading style(MD003, heading-style)
README.md
1-1: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
51-51: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
52-52: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
53-53: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
Additional comments not posted (4)
widget/README.md (1)
18-18
: LGTM!The repository reference update from jCenter to Maven Central is correct.
library/README.md (1)
23-23
: LGTM!The repository reference update from jCenter to Maven Central is correct.
README.md (2)
2-2
: LGTM!The build status badge update from Travis CI to GitHub Actions is correct.
53-53
: LGTM!The supported Android SDK version update from 30 to 34 is correct.
Tools
Markdownlint
53-53: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
@@ -13,9 +13,9 @@ Supported features: | |||
|
|||
[Documentation](https://github.com/uploadcare/uploadcare-android/blob/master/documentation/WIDGET.md) | |||
|
|||
## jCenter | |||
## Maven Central |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix heading style.
The heading style should be setext instead of atx for consistency.
- ## Maven Central
+ Maven Central
+ -------------
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
## Maven Central | |
Maven Central | |
------------- |
Tools
Markdownlint
16-16: Expected: setext; Actual: atx
Heading style(MD003, heading-style)
@@ -18,9 +18,9 @@ Supported features: | |||
|
|||
[Documentation](https://github.com/uploadcare/uploadcare-android/blob/master/documentation/LIBRARY.md) | |||
|
|||
## jCenter | |||
## Maven Central |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix heading style.
The heading style should be setext instead of atx for consistency.
- ## Maven Central
+ Maven Central
+ -------------
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
## Maven Central | |
Maven Central | |
------------- |
Tools
Markdownlint
21-21: Expected: setext; Actual: atx
Heading style(MD003, heading-style)
* Gradle 7.6 | ||
* JDK 11 | ||
* Android SDK 30 | ||
* Android SDK 34 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix unordered list style.
The unordered list style should use dashes instead of asterisks for consistency.
- * Gradle 7.6
- * JDK 11
- * Android SDK 34
+ - Gradle 7.6
+ - JDK 11
+ - Android SDK 34
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
* Gradle 7.6 | |
* JDK 11 | |
* Android SDK 30 | |
* Android SDK 34 | |
- Gradle 7.6 | |
- JDK 11 | |
- Android SDK 34 |
Tools
Markdownlint
51-51: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
52-52: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
53-53: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
Description
Updating the documentation in accordance with the latest changes.
Summary by CodeRabbit
README.md
to use GitHub Actions.README.md
.library/README.md
andwidget/README.md
.