Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation update #139

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Documentation update #139

merged 1 commit into from
Jul 3, 2024

Conversation

onthecrow
Copy link
Collaborator

@onthecrow onthecrow commented Jul 3, 2024

Description

Updating the documentation in accordance with the latest changes.

Summary by CodeRabbit

  • Documentation
    • Updated build status badge in README.md to use GitHub Actions.
    • Updated supported Android SDK version from 30 to 34 in README.md.
    • Changed references from jCenter to Maven Central for accessing the latest stable version in library/README.md and widget/README.md.

Copy link
Contributor

coderabbitai bot commented Jul 3, 2024

Walkthrough

The recent updates enhance the Uploadcare Android integration documentation by transitioning the build status badge from Travis CI to GitHub Actions, updating the supported Android SDK version to 34, and switching the repository reference from jCenter to Maven Central.

Changes

Files Change Summary
README.md Updated build status badge URL and Android SDK version
library/README.md,
widget/README.md Updated repository reference from jCenter to Maven Central

Poem

In the heart of code, where updates sprout,
The Android SDK climbed to thirty-four, no doubt,
From Travis to Actions, a badge anew,
Maven Central sits where jCenter once grew.
Libraries and widgets, all polished and bright,
A seamless upgrade, done just right.

🐇✨

Tip

AI model upgrade

gpt-4o model for reviews and chat is now live

OpenAI claims that this model is better at understanding and generating code than the previous models. Please join our Discord Community to provide any feedback or to report any issues.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b55c365 and af3880d.

Files selected for processing (3)
  • README.md (2 hunks)
  • library/README.md (1 hunks)
  • widget/README.md (1 hunks)
Additional context used
Markdownlint
widget/README.md

16-16: Expected: setext; Actual: atx
Heading style

(MD003, heading-style)

library/README.md

21-21: Expected: setext; Actual: atx
Heading style

(MD003, heading-style)

README.md

1-1: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


51-51: Expected: dash; Actual: asterisk
Unordered list style

(MD004, ul-style)


52-52: Expected: dash; Actual: asterisk
Unordered list style

(MD004, ul-style)


53-53: Expected: dash; Actual: asterisk
Unordered list style

(MD004, ul-style)

Additional comments not posted (4)
widget/README.md (1)

18-18: LGTM!

The repository reference update from jCenter to Maven Central is correct.

library/README.md (1)

23-23: LGTM!

The repository reference update from jCenter to Maven Central is correct.

README.md (2)

2-2: LGTM!

The build status badge update from Travis CI to GitHub Actions is correct.


53-53: LGTM!

The supported Android SDK version update from 30 to 34 is correct.

Tools
Markdownlint

53-53: Expected: dash; Actual: asterisk
Unordered list style

(MD004, ul-style)

@@ -13,9 +13,9 @@ Supported features:

[Documentation](https://github.com/uploadcare/uploadcare-android/blob/master/documentation/WIDGET.md)

## jCenter
## Maven Central
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix heading style.

The heading style should be setext instead of atx for consistency.

- ## Maven Central
+ Maven Central
+ -------------
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
## Maven Central
Maven Central
-------------
Tools
Markdownlint

16-16: Expected: setext; Actual: atx
Heading style

(MD003, heading-style)

@@ -18,9 +18,9 @@ Supported features:

[Documentation](https://github.com/uploadcare/uploadcare-android/blob/master/documentation/LIBRARY.md)

## jCenter
## Maven Central
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix heading style.

The heading style should be setext instead of atx for consistency.

- ## Maven Central
+ Maven Central
+ -------------
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
## Maven Central
Maven Central
-------------
Tools
Markdownlint

21-21: Expected: setext; Actual: atx
Heading style

(MD003, heading-style)

Comment on lines 51 to +53
* Gradle 7.6
* JDK 11
* Android SDK 30
* Android SDK 34
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix unordered list style.

The unordered list style should use dashes instead of asterisks for consistency.

- * Gradle 7.6
- * JDK 11
- * Android SDK 34
+ - Gradle 7.6
+ - JDK 11
+ - Android SDK 34
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
* Gradle 7.6
* JDK 11
* Android SDK 30
* Android SDK 34
- Gradle 7.6
- JDK 11
- Android SDK 34
Tools
Markdownlint

51-51: Expected: dash; Actual: asterisk
Unordered list style

(MD004, ul-style)


52-52: Expected: dash; Actual: asterisk
Unordered list style

(MD004, ul-style)


53-53: Expected: dash; Actual: asterisk
Unordered list style

(MD004, ul-style)

@rsedykh rsedykh merged commit 4404a62 into master Jul 3, 2024
3 checks passed
@rsedykh rsedykh deleted the documentation-update branch July 3, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants