Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add japanese #22

Merged
merged 2 commits into from
Dec 4, 2024
Merged

add japanese #22

merged 2 commits into from
Dec 4, 2024

Conversation

heocoi
Copy link
Contributor

@heocoi heocoi commented Mar 3, 2019

Hi,
I added a locale file for Japanese.

I'm using Uploadcare for a production web app and need to locale Social tabs.
Could you merge it soon?

Thanks.

@andrewshkovskii
Copy link
Contributor

andrewshkovskii commented Feb 11, 2020

@heocoi Hello. Thank you for your PR.

Sorry for little bit late response .. :)
There are missing translation keys for drive, current keys are:

      myFiles: 'My Files',
      shared: 'Shared with me',
      starred: 'Starred',
      search: 'Search',
      teamDrives: 'Team drives'

Same for oneDrive:

        myFiles: 'My files',
        shared: 'Shared with me',
        sharepoint: 'SharePoint',
        myDrives: 'My drives',
        groups: 'My groups'

And gphotos:

      myAlbums: 'Albums',
      myPhotos: 'Photos'

Copy link
Contributor

@andrewshkovskii andrewshkovskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment, please

ja.js Outdated Show resolved Hide resolved
Co-authored-by: Andrei Baryshnikov <[email protected]>
@nd0ut nd0ut self-requested a review December 4, 2024 12:21
@nd0ut nd0ut merged commit 66af762 into uploadcare:master Dec 4, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants