fix: safari system file dialog issues

[nd0ut]

Description

Checklist

• Tests (if applicable)
• Documentation (if applicable)
• Changelog stub (or use conventional commit messages)

Summary by CodeRabbit

• New Features

  • Enhanced file input handling for improved user experience.
  • Introduced a standardized attribute for temporary input elements.

• Bug Fixes

  • Streamlined the process for querying and removing temporary input elements.

• Refactor

  • Improved event handling for file input changes, ensuring cleaner interaction and DOM management.

[coderabbitai]

Walkthrough

The changes enhance the file input handling logic in the UploaderPublicApi class. A new constant, INPUT_ATTR_NAME, is introduced for temporary input elements. The event listener for file input changes has been restructured to use addEventListener, allowing for better event management. Additionally, the removal of temporary input elements is explicitly handled, resulting in a cleaner DOM. These modifications aim to improve code readability and maintainability.

Changes

File	Change Summary
abstract/UploaderPublicApi.js	Introduced INPUT_ATTR_NAME for standardizing input attributes; restructured event listener to use addEventListener; ensured proper cleanup of temporary input elements.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant FileInput
    participant UploaderPublicApi

    User->>FileInput: Select files
    FileInput->>UploaderPublicApi: Trigger change event
    UploaderPublicApi->>UploaderPublicApi: Process files
    UploaderPublicApi->>FileInput: Remove temporary input

Loading

Poem

🐰 In the code where changes dwell,
A tidy input, all is well.
With attributes set, and events so neat,
The rabbit hops, in rhythm, with beat!
Clean and clear, the workflow flows,
Hooray for code, as progress grows! 🌟

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 90531f2 and 5727f90.

Files selected for processing (1)

• abstract/UploaderPublicApi.js (2 hunks)

Additional comments not posted (3)

abstract/UploaderPublicApi.js (3)

151-151: LGTM: Introduction of INPUT_DATA_ATTR.

The definition of INPUT_DATA_ATTR enhances code readability and maintainability.

---

Line range hint 153-181: LGTM: File input creation and event handling improvements.

The use of addEventListener with the once option and the removal of the fileInput element enhance the robustness of the code.

---

183-183: LGTM: Streamlined removal of temporary input elements.

The use of INPUT_DATA_ATTR for querying and removing elements improves code clarity and maintainability.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5727f90 and 768fdc6.

Files selected for processing (1)

• abstract/UploaderPublicApi.js (4 hunks)

Files skipped from review as they are similar to previous changes (1)

• abstract/UploaderPublicApi.js