Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update symbiote to v2 #714

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Update symbiote to v2 #714

wants to merge 4 commits into from

Conversation

nd0ut
Copy link
Member

@nd0ut nd0ut commented Aug 1, 2024

No description provided.

Copy link
Contributor

coderabbitai bot commented Aug 1, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@@ -1,5 +1,5 @@
import { FormInput } from '../../index.js';

() => <uc-form-input ctx-name="my-uploader" />;
() => <uc-form-input ctx="my-uploader" />;

Check warning

Code scanning / CodeQL

Expression has no effect Warning test

This expression has no effect.
@@ -4,28 +4,28 @@
import { OutputFileEntry, FuncCollectionValidator, FuncFileValidator } from '../index.js';

// @ts-expect-error untyped props
() => <uc-config ctx-name="1" something="wrong"></uc-config>;
() => <uc-config ctx="1" something="wrong"></uc-config>;

Check warning

Code scanning / CodeQL

Expression has no effect Warning test

This expression has no effect.
// allow common html attributes and required ctx-name
() => <uc-config ctx-name="1" id="1" class="1" hidden></uc-config>;
// allow common html attributes and required ctx
() => <uc-config ctx="1" id="1" class="1" hidden></uc-config>;

Check warning

Code scanning / CodeQL

Expression has no effect Warning test

This expression has no effect.

// allow key prop
() => <uc-config ctx-name="1" key={1}></uc-config>;
() => <uc-config ctx="1" key={1}></uc-config>;

Check warning

Code scanning / CodeQL

Expression has no effect Warning test

This expression has no effect.
};

// accept config attributes
() => <uc-config ctx-name="1" multiple multipleMax={1} multipleMin={2} accept="str" />;
() => <uc-config ctx="1" multiple multipleMax={1} multipleMin={2} accept="str" />;

Check warning

Code scanning / CodeQL

Expression has no effect Warning test

This expression has no effect.
types/test/uc-cloud-image-editor.test-d.tsx Fixed Show fixed Hide fixed
() => <uc-cloud-image-editor ctx-name="my-editor" css-src="url" uuid="123124" />;
() => <uc-cloud-image-editor ctx-name="my-editor" css-src="url" uuid="123124" tabs="tab" crop-preset="preset" />;
() => <uc-cloud-image-editor ctx-name="my-editor" css-src="url" cdn-url="url" />;
() => <uc-cloud-image-editor ctx="my-editor" css-src="url" uuid="123124" />;

Check warning

Code scanning / CodeQL

Expression has no effect Warning test

This expression has no effect.
() => <uc-cloud-image-editor ctx-name="my-editor" css-src="url" uuid="123124" tabs="tab" crop-preset="preset" />;
() => <uc-cloud-image-editor ctx-name="my-editor" css-src="url" cdn-url="url" />;
() => <uc-cloud-image-editor ctx="my-editor" css-src="url" uuid="123124" />;
() => <uc-cloud-image-editor ctx="my-editor" css-src="url" uuid="123124" tabs="tab" crop-preset="preset" />;

Check warning

Code scanning / CodeQL

Expression has no effect Warning test

This expression has no effect.
() => <uc-cloud-image-editor ctx-name="my-editor" css-src="url" cdn-url="url" />;
() => <uc-cloud-image-editor ctx="my-editor" css-src="url" uuid="123124" />;
() => <uc-cloud-image-editor ctx="my-editor" css-src="url" uuid="123124" tabs="tab" crop-preset="preset" />;
() => <uc-cloud-image-editor ctx="my-editor" css-src="url" cdn-url="url" />;

Check warning

Code scanning / CodeQL

Expression has no effect Warning test

This expression has no effect.
@nd0ut nd0ut force-pushed the feat/symbiote-v2 branch from 95b955e to eb34af9 Compare August 1, 2024 19:50
// @ts-expect-error - no css-url
() => <uc-cloud-image-editor ctx-name="my-uploader" />;
// @ts-expect-error - no cdn-src or uuid
() => <uc-cloud-image-editor ctx="my-uploader" />;

Check warning

Code scanning / CodeQL

Expression has no effect Warning test

This expression has no effect.
@@ -0,0 +1,5 @@
() => <uc-config ctx="my-uploader" />;

Check warning

Code scanning / CodeQL

Expression has no effect Warning test

This expression has no effect.
@@ -0,0 +1,5 @@
() => <uc-config ctx="my-uploader" />;
() => <uc-config ctx-name="my-uploader" />;

Check warning

Code scanning / CodeQL

Expression has no effect Warning test

This expression has no effect.
() => <uc-config ctx-name="my-uploader" />;

// @ts-expect-error - should fall when both ctx and ctx-name are provided
() => <uc-config ctx-name="my-uploader" ctx="another-ctx" />;

Check warning

Code scanning / CodeQL

Expression has no effect Warning test

This expression has no effect.
@nd0ut nd0ut force-pushed the feat/symbiote-v2 branch from eb34af9 to 58a452e Compare August 1, 2024 19:57
@nd0ut nd0ut requested a review from egordidenko August 2, 2024 08:40
@nd0ut nd0ut force-pushed the feat/symbiote-v2 branch from 58a452e to 295f777 Compare August 2, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant