fix(events): Added status after deleting files in idle

[egordidenko]

Description

Checklist

• Tests (if applicable)
• Documentation (if applicable)
• Changelog stub (or use conventional commit messages)

Summary by CodeRabbit

• Bug Fixes
  • Improved logic for upload success checks to ensure uploads are only marked successful if there is at least one item uploaded.
  • Enhanced validation for output collection state to confirm success only when there are entries present.

[coderabbitai]

Walkthrough

This update focuses on enhancing the success criteria for upload operations. Changes were made to the UploaderBlock class and the buildOutputCollectionState function to ensure an upload is only considered successful if there are no errors and there is at least one successful entry.

Changes

File	Change Summary
abstract/UploaderBlock.js	Modified the condition for emitting COMMON_UPLOAD_SUCCESS to include a check for non-empty uploads (uploadCollection.size > 0).
abstract/buildOutputCollectionState.js	Updated the isSuccess method to verify that state.allEntries.length > 0 in addition to error-free and complete entries.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UploaderBlock
    participant EventManager

    User ->> UploaderBlock: Trigger Upload
    UploaderBlock ->> UploaderBlock: Process Upload (Check Conditions)
    alt Successful Upload
        UploaderBlock ->> EventManager: Emit COMMON_UPLOAD_SUCCESS
    else Unsuccessful Upload
        UploaderBlock ->> EventManager: Emit COMMON_UPLOAD_FAIL
    end

Loading

Poem

In fields of code where bytes do play,
Success now finds a brighter way.
With checks anew, uploads shine,
Errors none, completeness fine.
A rabbit’s joy in logic's light,
Hopping through the code at night. 🐇✨

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (1)

abstract/UploaderBlock.js (1)

Line range hint 585-585: Remove redundant double-negation.

The double-negation in line 585 is unnecessary and can be removed for cleaner code.

- !!this.cfg.checkForUrlDuplicates
+ this.cfg.checkForUrlDuplicates

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4fdf9a0 and f62598d.

Files selected for processing (2)

• abstract/UploaderBlock.js (1 hunks)
• abstract/buildOutputCollectionState.js (1 hunks)

Additional context used

Biome

abstract/UploaderBlock.js

[error] 585-585: Avoid redundant double-negation.

It is not necessary to use double-negation when a value will already be coerced to a boolean.
Unsafe fix: Remove redundant double-negation

(lint/complexity/noExtraBooleanCast)

Additional comments not posted (2)

abstract/buildOutputCollectionState.js (1)

78-82: Approved with a suggestion for clarity improvement.

The updated logic in isSuccess now correctly checks if there are any entries before considering success. This is a good improvement for accuracy.

[SUGGESTION]
Consider adding a comment above the isSuccess method to explain why the check for state.allEntries.length > 0 is necessary. This would improve code readability and maintainability.

abstract/UploaderBlock.js (1)

433-433: Approved but consider potential redundancy.

The added condition uploadCollection.size > 0 ensures that there are items before emitting a success event. However, this might be redundant since the equality check with loadedItems.length implicitly covers this scenario.