Feat/custom validate func #667
Conversation
… fileValidators and collectionValidators
WalkthroughThe changes introduce a centralized Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UploaderBlock
participant ValidationManager
participant FileValidator
participant CollectionValidator
User->>UploaderBlock: Upload File/Collection
UploaderBlock->>ValidationManager: Run Validators
ValidationManager->>FileValidator: Validate File
FileValidator-->>ValidationManager: Return Validation Result
ValidationManager->>CollectionValidator: Validate Collection
CollectionValidator-->>ValidationManager: Return Validation Result
ValidationManager-->>UploaderBlock: Return Validation Results
UploaderBlock-->>User: Display Validation Results
Poem
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Outside diff range and nitpick comments (1)
blocks/Config/Config.js (1)
Line range hint
61-61: Prefer template literals over string concatenation for better readability and consistency.- const getLocalPropName = (key) => '__' + key; + const getLocalPropName = (key) => `__${key}`;
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (15)
- abstract/UploaderBlock.js (8 hunks)
- abstract/ValidationManager.js (1 hunks)
- blocks/Config/Config.js (2 hunks)
- blocks/Config/initialConfig.js (1 hunks)
- blocks/Config/normalizeConfigValue.js (2 hunks)
- demo/raw-regular.html (1 hunks)
- types/exported.d.ts (3 hunks)
- utils/validators/collection/index.js (1 hunks)
- utils/validators/collection/validateCollectionUploadError.js (1 hunks)
- utils/validators/collection/validateMultiple.js (1 hunks)
- utils/validators/file/index.js (1 hunks)
- utils/validators/file/validateFileType.js (1 hunks)
- utils/validators/file/validateIsImage.js (1 hunks)
- utils/validators/file/validateMaxSizeLimit.js (1 hunks)
- utils/validators/file/validateUploadError.js (1 hunks)
Files skipped from review due to trivial changes (4)
- blocks/Config/initialConfig.js
- demo/raw-regular.html
- utils/validators/collection/index.js
- utils/validators/file/index.js
Additional Context Used
Biome (30)
abstract/UploaderBlock.js (14)
270-272: Prefer for...of instead of forEach.
270-270: The computed expression can be simplified without the use of a string literal.
277-277: The computed expression can be simplified without the use of a string literal.
307-307: The computed expression can be simplified without the use of a string literal.
440-443: The call chain .map().flat() can be replaced with a single .flatMap() call.
511-513: Prefer for...of instead of forEach.
525-528: Prefer for...of instead of forEach.
639-639: Avoid redundant double-negation.
70-70: This let declares a variable that is only assigned once.
249-249: This let declares a variable that is only assigned once.
481-481: This let declares a variable that is only assigned once.
484-484: This let declares a variable that is only assigned once.
602-602: This let declares a variable that is only assigned once.
635-635: This let declares a variable that is only assigned once.
blocks/Config/Config.js (6)
61-61: Template literals are preferred over string concatenation.
166-166: Do not use template literals if interpolation and special-character handling are not needed.
121-121: This aliasing of this is unnecessary.
144-144: This aliasing of this is unnecessary.
176-176: This aliasing of this is unnecessary.
222-222: This aliasing of this is unnecessary.
types/exported.d.ts (8)
19-19: Unexpected any. Specify a different type.
20-20: Unexpected any. Specify a different type.
278-279: This empty export is useless because there's another export or import.
1-1: All these imports are only used as types.
1-2: All these imports are only used as types.
2-3: All these imports are only used as types.
111-111: Don't use '{}' as a type.
279-279: All exports are only types and should thus use export type.
utils/validators/file/validateUploadError.js (2)
20-35: This else clause can be omitted because previous branches break early.
27-35: This else clause can be omitted because previous branches break early.
Additional comments not posted (19)
utils/validators/collection/validateCollectionUploadError.js (1)
3-11: The implementation ofvalidateCollectionUploadErroraligns well with the PR's objectives to enhance validation mechanisms. The use ofbuildCollectionFileErrorto handle error scenarios is appropriate.utils/validators/file/validateMaxSizeLimit.js (1)
5-16: ThevalidateMaxSizeLimitfunction is correctly implemented to check for file size limits and handle errors appropriately. Good use of configuration values and error handling.utils/validators/file/validateIsImage.js (1)
5-27: ThevalidateIsImagefunction is well-implemented, handling various edge cases effectively and aligning with the PR's objectives to enhance file validation mechanisms.utils/validators/collection/validateMultiple.js (1)
3-38: ThevalidateMultiplefunction is correctly implemented to enforce file count limits within collections, using configuration values effectively and handling errors appropriately.utils/validators/file/validateFileType.js (1)
5-31: ThevalidateFileTypefunction is well-implemented, using a combination of mime type and file extension checks to ensure that only allowed file types are processed. Good handling of edge cases and error scenarios.abstract/ValidationManager.js (6)
1-1: Ensure TypeScript checks are enabled for better type safety.
2-9: Imports are well-organized and relevant to the functionality of theValidationManager.
11-27: Type definitions forFuncFileValidatorandFuncCollectionValidatorare clear and well-documented.
29-59: TheValidationManagerclass is well-structured with clear separation of concerns. The constructor initializes necessary properties and subscribes to configuration changes effectively.
73-101: TherunCollectionValidatorsmethod aggregates errors from collection validators and handles different types of return values (single error or array of errors) correctly. It also emits an event if there are any errors, which is a good practice for asynchronous error handling.
103-134: Private methods_runFileValidatorsForEntry,_runCustomValidatorsEntry, and_commonValidationare well encapsulated and maintain clean separation of concerns within the class. They also make good use of the provided validators.blocks/Config/normalizeConfigValue.js (2)
77-88: TheasValidatorsfunction correctly checks if the input is an array and throws an appropriate error if not. This is crucial for ensuring that the validators configuration is always in the expected format.
156-157: The mapping forfileValidatorsandcollectionValidatorsuses theasValidatorsfunction to ensure type safety. This is a good practice as it prevents configuration errors from propagating further into the application.blocks/Config/Config.js (1)
Line range hint
22-33: The addition offileValidatorsandcollectionValidatorstocomplexConfigKeysensures that these configurations are treated appropriately as complex types, which is necessary for their correct handling in the configuration system.types/exported.d.ts (1)
75-76: The type definitions forfileValidatorsandcollectionValidatorsare correctly nullable, allowing for configurations where validators may not be provided.abstract/UploaderBlock.js (4)
23-24: Proper use of theValidationManagerimport to facilitate new validation logic within theUploaderBlock.
77-79: Initialization ofValidationManageronly if it has not been previously added is a good practice to avoid unnecessary re-instantiations.
86-89: Getter forvalidationManageris concise and correctly handles the case where the manager might not be present.
397-400: The integration ofValidationManagermethods within the_handleCollectionUpdatemethod ensures that validations are run at appropriate times, enhancing the robustness of file handling.
There was a problem hiding this comment.
Actionable comments posted: 2
Outside diff range and nitpick comments (1)
types/exported.d.ts (1)
Line range hint
279-279: Remove the empty export statement as it serves no purpose.- export {};
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- blocks/Config/normalizeConfigValue.js (2 hunks)
- types/exported.d.ts (3 hunks)
- utils/validators/file/validateUploadError.js (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- blocks/Config/normalizeConfigValue.js
Additional Context Used
Biome (7)
types/exported.d.ts (6)
278-279: This empty export is useless because there's another export or import.
1-1: All these imports are only used as types.
1-2: All these imports are only used as types.
2-3: All these imports are only used as types.
111-111: Don't use '{}' as a type.
279-279: All exports are only types and should thus use export type.
utils/validators/file/validateUploadError.js (1)
20-27: This else clause can be omitted because previous branches break early.
egordidenko
force-pushed
the
feat/custom-validate-func
branch
from
052fd05 to
8412b19
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (3)
types/exported.d.ts (3)
Line range hint
278-279: Remove the empty export statement as it serves no purpose.- export {};
Line range hint
279-279: Convert all exports toexport typesince they are only type definitions.- export type UploadError = import('@uploadcare/upload-client').UploadError; - export type UploadcareFile = import('@uploadcare/upload-client').UploadcareFile; - export type NetworkError = import('@uploadcare/upload-client').NetworkError; - export type UploadcareGroup = import('@uploadcare/upload-client').UploadcareGroup; - export type Metadata = import('@uploadcare/upload-client').Metadata; - export type MetadataCallback = (fileEntry: OutputFileEntry) => Promise<Metadata> | Metadata; - export type LocaleDefinitionOverride = Record<string, LocaleDefinition>; - export type SecureDeliveryProxyUrlResolver = ( + export type UploadError = import('@uploadcare/upload-client').UploadError; + export type UploadcareFile = import('@uploadcare/upload-client').UploadcareFile; + export type NetworkError = import('@uploadcare/upload-client').NetworkError; + export type UploadcareGroup = import('@uploadcare/upload-client').UploadcareGroup; + export type Metadata = import('@uploadcare/upload-client').Metadata; + export type MetadataCallback = (fileEntry: OutputFileEntry) => Promise<Metadata> | Metadata; + export type LocaleDefinitionOverride = Record<string, LocaleType>; + export type SecureDeliveryProxyUrlResolver = (
Line range hint
111-111: Avoid using '{}' as a type for error payloads. Specify a more appropriate type or use 'unknown' if the type is not determined.- SOME_FILES_HAS_ERRORS: {}; + SOME_FILES_HAS_ERRORS: unknown;
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- blocks/Config/normalizeConfigValue.js (2 hunks)
- types/exported.d.ts (3 hunks)
- utils/validators/file/validateUploadError.js (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- blocks/Config/normalizeConfigValue.js
- utils/validators/file/validateUploadError.js
Additional Context Used
Biome (3)
types/exported.d.ts (3)
278-279: This empty export is useless because there's another export or import.
111-111: Don't use '{}' as a type.
279-279: All exports are only types and should thus use export type.
There was a problem hiding this comment.
Actionable comments posted: 2
Outside diff range and nitpick comments (1)
types/exported.d.ts (1)
Line range hint
114-114: Don't use '{}' as a type. Specify a more precise type or use 'unknown' if the exact type cannot be determined.- SOME_FILES_HAS_ERRORS: {}; + SOME_FILES_HAS_ERRORS: Record<string, unknown>;
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (10)
- abstract/CTX.js (1 hunks)
- abstract/ValidationManager.js (1 hunks)
- abstract/buildOutputCollectionState.js (1 hunks)
- types/exported.d.ts (11 hunks)
- utils/validators/collection/validateCollectionUploadError.js (1 hunks)
- utils/validators/collection/validateMultiple.js (1 hunks)
- utils/validators/file/validateFileType.js (1 hunks)
- utils/validators/file/validateIsImage.js (1 hunks)
- utils/validators/file/validateMaxSizeLimit.js (1 hunks)
- utils/validators/file/validateUploadError.js (1 hunks)
Files skipped from review as they are similar to previous changes (7)
- abstract/ValidationManager.js
- utils/validators/collection/validateCollectionUploadError.js
- utils/validators/collection/validateMultiple.js
- utils/validators/file/validateFileType.js
- utils/validators/file/validateIsImage.js
- utils/validators/file/validateMaxSizeLimit.js
- utils/validators/file/validateUploadError.js
Additional context used
Biome
types/exported.d.ts
[error] 283-284: This empty export is useless because there's another export or import.
[error] 114-114: Don't use '{}' as a type.
[error] 284-284: All exports are only types and should thus use export type.
Additional comments not posted (5)
abstract/CTX.js (1)
30-30: Update the type annotation to match the newValidationManagerstructure.Verification successful
The type
OutputCollectionErrorTypeis defined and used in multiple places within the codebase, includingValidationManager. The definition is found intypes/exported.d.tsand it is used in various files such asabstract/CTX.js,abstract/uploadEntrySchema.js, andabstract/ValidationManager.js.
types/exported.d.ts: DefinesOutputCollectionErrorType.abstract/CTX.js: UsesOutputCollectionErrorTypein a type annotation.abstract/ValidationManager.js: UsesOutputCollectionErrorTypein type definitions and function signatures.This confirms that the type annotation in
abstract/CTX.jsis consistent with theValidationManagerstructure.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the type `OutputCollectionErrorType` is correctly defined and used in the `ValidationManager`. # Test: Search for the type definition and usage. Expect: Correct definition and usage. ast-grep --lang javascript --pattern $'type OutputCollectionErrorType { $$$ }'Length of output: 540
Script:
#!/bin/bash # Description: Verify that the type `OutputCollectionErrorType` is correctly defined and used in the `ValidationManager`. # Test 1: Search for the type definition of `OutputCollectionErrorType`. ast-grep --lang javascript --pattern 'type OutputCollectionErrorType = $_' # Test 2: Search for the usage of `OutputCollectionErrorType` in the codebase. rg 'OutputCollectionErrorType'Length of output: 1731
abstract/buildOutputCollectionState.js (1)
46-46: Ensure theerrorsfunction correctly handles the new error types fromValidationManager.types/exported.d.ts (3)
1-3: Correctly marked imports used only for types withimport typeto optimize bundling.
19-20: The use ofanyin type definitions forFileValidatorandCollectionValidatorreduces type safety. Consider specifying more precise types or at least usingunknownif the exact types cannot be determined.- export type FileValidator = FuncFileValidator | any; - export type CollectionValidator = FuncCollectionValidator | any; + export type FileValidator = FuncFileValidator | unknown; + export type CollectionValidator = FuncCollectionValidator | unknown;Likely invalid or redundant comment.
75-76: Ensure thatfileValidatorsandcollectionValidatorsare properly initialized and used throughout the codebase.
(this._blockInstance.cfg.fileValidators ?? []).map(fn => (...args) => ({...fn(...args), type: 'CUSTOM_TYPE'})) |
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (1)
types/test/lr-config.test-d.tsx (1)
74-92: The addition of custom validatorsmaxSizeandmaxCollectionis correctly implemented. The structure and type usage are consistent with the new validation system.Consider adding comments to describe the purpose of each validator for better maintainability.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (10)
- abstract/ValidationManager.js (1 hunks)
- blocks/Config/normalizeConfigValue.js (2 hunks)
- types/exported.d.ts (11 hunks)
- types/test/lr-config.test-d.tsx (2 hunks)
- utils/validators/collection/validateCollectionUploadError.js (1 hunks)
- utils/validators/collection/validateMultiple.js (1 hunks)
- utils/validators/file/validateFileType.js (1 hunks)
- utils/validators/file/validateIsImage.js (1 hunks)
- utils/validators/file/validateMaxSizeLimit.js (1 hunks)
- utils/validators/file/validateUploadError.js (1 hunks)
Files skipped from review as they are similar to previous changes (8)
- abstract/ValidationManager.js
- blocks/Config/normalizeConfigValue.js
- utils/validators/collection/validateCollectionUploadError.js
- utils/validators/collection/validateMultiple.js
- utils/validators/file/validateFileType.js
- utils/validators/file/validateIsImage.js
- utils/validators/file/validateMaxSizeLimit.js
- utils/validators/file/validateUploadError.js
Additional context used
Biome
types/exported.d.ts
[error] 283-284: This empty export is useless because there's another export or import. (lint/complexity/noUselessEmptyExport)
This import makes useless the empty export.
Safe fix: Remove this useless empty export.
[error] 114-114: Don't use '{}' as a type. (lint/complexity/noBannedTypes)
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
Additional comments not posted (3)
types/test/lr-config.test-d.tsx (1)
5-5: Import ofFuncCollectionValidatorandFuncFileValidatorlooks correct and aligns with the new validation logic.types/exported.d.ts (2)
1-3: Correct use ofimport typeforLocaleDefinition,complexConfigKeys, and validator types. This optimizes bundling by ensuring these imports are only used for type checking.
19-20: The type definitions forFileValidatorandCollectionValidatoras arrays of function validators are appropriate and align with the new validation system.
egordidenko
force-pushed
the
feat/custom-validate-func
branch
from
02836fa to
a9b3505
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (2)
blocks/UploadList/UploadList.js (1)
Line range hint
14-14: Consider binding methods in the constructor instead of using arrow functions in class properties.This can enhance performance by avoiding the creation of new function instances on each component instantiation.
types/exported.d.ts (1)
Line range hint
116-116: Replace{}withunknownin type definitions for better type safety.- SOME_FILES_HAS_ERRORS: {}; + SOME_FILES_HAS_ERRORS: unknown;
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (9)
- abstract/CTX.js (1 hunks)
- abstract/ValidationManager.js (1 hunks)
- abstract/buildOutputCollectionState.js (1 hunks)
- blocks/Config/normalizeConfigValue.js (2 hunks)
- blocks/UploadList/UploadList.js (1 hunks)
- types/exported.d.ts (11 hunks)
- types/test/lr-config.test-d.tsx (2 hunks)
- utils/validators/collection/validateCollectionUploadError.js (1 hunks)
- utils/validators/collection/validateMultiple.js (1 hunks)
Files skipped from review as they are similar to previous changes (7)
- abstract/CTX.js
- abstract/ValidationManager.js
- abstract/buildOutputCollectionState.js
- blocks/Config/normalizeConfigValue.js
- types/test/lr-config.test-d.tsx
- utils/validators/collection/validateCollectionUploadError.js
- utils/validators/collection/validateMultiple.js
Additional context used
Biome
types/exported.d.ts
[error] 289-290: This empty export is useless because there's another export or import. (lint/complexity/noUselessEmptyExport)
This import makes useless the empty export.
Safe fix: Remove this useless empty export.
[error] 116-116: Don't use '{}' as a type. (lint/complexity/noBannedTypes)
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
Additional comments not posted (4)
blocks/UploadList/UploadList.js (3)
82-82: The implementation of throttling in_throttledHandleCollectionUpdateis efficient and correctly checks component connectivity before proceeding.
82-82: The logic in_updateUploadsStatefor managing button states and upload progress is clear and well-implemented.
Line range hint
14-14: TODO: Address potential performance issues with many files.Consider profiling the application to determine if the performance impact is significant and explore optimization strategies if necessary.
types/exported.d.ts (1)
1-3: Correct use ofimport typefor type-only imports ensures they are erased during TypeScript compilation, optimizing the final bundle size.
| ); | ||
|
|
||
| export { EventType, EventPayload } from '../blocks/UploadCtxProvider/EventEmitter'; | ||
|
|
||
| export {}; | ||
| export { }; |
There was a problem hiding this comment.
Remove the redundant empty export statement to clean up the code.
- export { };Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| export { }; |
Tools
Biome
[error] 289-290: This empty export is useless because there's another export or import. (lint/complexity/noUselessEmptyExport)
This import makes useless the empty export.
Safe fix: Remove this useless empty export.
egordidenko
force-pushed
the
feat/custom-validate-func
branch
from
a9b3505 to
e4c3d22
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
types/exported.d.ts (1)
Line range hint
116-116: Avoid using '{}' as a type since it implies any non-nullish value, reducing type safety.- SOME_FILES_HAS_ERRORS: {}; + SOME_FILES_HAS_ERRORS: Record<string, unknown>;
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (9)
- abstract/CTX.js (1 hunks)
- abstract/ValidationManager.js (1 hunks)
- abstract/buildOutputCollectionState.js (1 hunks)
- blocks/Config/normalizeConfigValue.js (2 hunks)
- blocks/UploadList/UploadList.js (1 hunks)
- types/exported.d.ts (11 hunks)
- types/test/lr-config.test-d.tsx (2 hunks)
- utils/validators/collection/validateCollectionUploadError.js (1 hunks)
- utils/validators/collection/validateMultiple.js (1 hunks)
Files skipped from review as they are similar to previous changes (8)
- abstract/CTX.js
- abstract/ValidationManager.js
- abstract/buildOutputCollectionState.js
- blocks/Config/normalizeConfigValue.js
- blocks/UploadList/UploadList.js
- types/test/lr-config.test-d.tsx
- utils/validators/collection/validateCollectionUploadError.js
- utils/validators/collection/validateMultiple.js
Additional context used
Biome
types/exported.d.ts
[error] 293-294: This empty export is useless because there's another export or import. (lint/complexity/noUselessEmptyExport)
This import makes useless the empty export.
Safe fix: Remove this useless empty export.
[error] 116-116: Don't use '{}' as a type. (lint/complexity/noBannedTypes)
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
Additional comments not posted (5)
types/exported.d.ts (5)
1-3: Useimport typefor imports used only in type positions to optimize bundling.
5-5: Exporting types directly from another module is efficient and clear.
21-22: The renaming ofFileValidatorsandCollectionValidatorsto plural forms aligns with their usage as arrays of validators.
294-294: Remove the redundant empty export statement to clean up the code.Tools
Biome
[error] 293-294: This empty export is useless because there's another export or import. (lint/complexity/noUselessEmptyExport)
This import makes useless the empty export.
Safe fix: Remove this useless empty export.
77-78: Ensure thatfileValidatorsandcollectionValidatorsare properly initialized and used in the configuration to prevent runtime errors.Verification successful
The search results indicate that
fileValidatorsandcollectionValidatorsare indeed initialized and used in various configuration files, includingblocks/Config/normalizeConfigValue.js,blocks/Config/Config.js,blocks/Config/initialConfig.js, andabstract/ValidationManager.js. This confirms that they are properly integrated into the configuration.
blocks/Config/normalizeConfigValue.js: Validators are typed and imported.blocks/Config/Config.js: Validators are listed as configuration properties.blocks/Config/initialConfig.js: Validators are initialized as empty arrays.abstract/ValidationManager.js: Validators are assigned specific validation functions.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the initialization and usage of `fileValidators` and `collectionValidators`. # Test: Search for the initialization and usage of these validators. Expect: Proper initialization and usage. rg --type typescript $'fileValidators|collectionValidators'Length of output: 95
Script:
#!/bin/bash # Description: Verify the initialization and usage of `fileValidators` and `collectionValidators`. # Test: Search for the initialization and usage of these validators. Expect: Proper initialization and usage. rg --type ts 'fileValidators|collectionValidators'Length of output: 324
Script:
#!/bin/bash # Description: Verify the initialization and usage of `fileValidators` and `collectionValidators` in configuration files. # Test: Search for the initialization and usage of these validators in configuration files. Expect: Proper initialization and usage. rg 'fileValidators|collectionValidators' --glob '!**/test/**'Length of output: 1380
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- demo/validators.html (1 hunks)
Additional comments not posted (2)
demo/validators.html (2)
1-17: HTML structure and resource links are correctly set up for modern web applications.
18-22: Script for registering blocks is correctly implemented.
demo/validators.html
Outdated
| <script type="module"> | ||
| const config = document.querySelector("lr-config") | ||
|
|
||
| const imagesOnly = (fileInfo, block) => { | ||
| if (!fileInfo.isImage) { | ||
| return { | ||
| message: "This isn't image", | ||
| payload: { | ||
| entry: fileInfo | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| config.fileValidators = [imagesOnly] | ||
|
|
||
| config.collectionValidators = [] |
There was a problem hiding this comment.
The custom validator imagesOnly lacks a return statement when the file is an image, which might lead to undefined behavior.
const imagesOnly = (fileInfo, block) => {
if (!fileInfo.isImage) {
return {
message: "This isn't image",
payload: {
entry: fileInfo
}
}
}
+ return true; // Assuming true represents a successful validation
}Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| <script type="module"> | |
| const config = document.querySelector("lr-config") | |
| const imagesOnly = (fileInfo, block) => { | |
| if (!fileInfo.isImage) { | |
| return { | |
| message: "This isn't image", | |
| payload: { | |
| entry: fileInfo | |
| } | |
| } | |
| } | |
| } | |
| config.fileValidators = [imagesOnly] | |
| config.collectionValidators = [] | |
| <script type="module"> | |
| const config = document.querySelector("lr-config") | |
| const imagesOnly = (fileInfo, block) => { | |
| if (!fileInfo.isImage) { | |
| return { | |
| message: "This isn't image", | |
| payload: { | |
| entry: fileInfo | |
| } | |
| } | |
| } | |
| return true; // Assuming true represents a successful validation | |
| } | |
| config.fileValidators = [imagesOnly] | |
| config.collectionValidators = [] |
egordidenko
force-pushed
the
feat/custom-validate-func
branch
from
13023dc to
a5aac80
Compare
egordidenko
force-pushed
the
feat/custom-validate-func
branch
from
a5aac80 to
ff6aa1a
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- demo/validators.html (1 hunks)
Additional comments not posted (2)
demo/validators.html (2)
1-36: HTML structure and meta tags are correctly set up for modern web applications.
18-35: JavaScript imports and locale definitions are correctly implemented.
| const imagesOnly = (fileInfo, ctx) => { | ||
| if (fileInfo.isImage) { | ||
| return { | ||
| message: ctx.l10n('file-is-not-an-image-type'), | ||
| payload: { | ||
| entry: fileInfo | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Fix the inverted logic in the imagesOnly validator and add a return statement for valid cases.
const imagesOnly = (fileInfo, ctx) => {
- if (fileInfo.isImage) {
+ if (!fileInfo.isImage) {
return {
message: ctx.l10n('file-is-not-an-image-type'),
payload: {
entry: fileInfo
}
}
}
+ return true; // Assuming true represents a successful validation
}Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const imagesOnly = (fileInfo, ctx) => { | |
| if (fileInfo.isImage) { | |
| return { | |
| message: ctx.l10n('file-is-not-an-image-type'), | |
| payload: { | |
| entry: fileInfo | |
| } | |
| } | |
| } | |
| } | |
| const imagesOnly = (fileInfo, ctx) => { | |
| if (!fileInfo.isImage) { | |
| return { | |
| message: ctx.l10n('file-is-not-an-image-type'), | |
| payload: { | |
| entry: fileInfo | |
| } | |
| } | |
| } | |
| return true; // Assuming true represents a successful validation | |
| } |
egordidenko
force-pushed
the
feat/custom-validate-func
branch
from
ff6aa1a to
de53a9a
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- abstract/ValidationManager.js (1 hunks)
- demo/validators.html (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- abstract/ValidationManager.js
- demo/validators.html
Description
Checklist
Summary by CodeRabbit
New Features
ValidationManagerto handle file and collection validation, improving the validation process.Bug Fixes
Documentation
Refactor
ValidationManager, removing redundant code.Style