Emit events on `lr-upload-ctx-provider` block #553

nd0ut · 2023-11-01T13:38:48Z

Description

github-advanced-security

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

types/test/events.test-d.ts

+
+const ctx: UploadCtxProvider = null as unknown as UploadCtxProvider;
+
+ctx.addEventListener('data-output', (e) => {


types/test/lr-config.test-d.tsx

+() => <lr-config ctx-name="1" key={1}></lr-config>;
+
+// allow useRef hook
+() => {


types/test/lr-config.test-d.tsx

+};
+
+// allow callback ref
+() => {


types/test/lr-config.test-d.tsx

+};
+
+// allow createRef
+() => {


types/test/lr-config.test-d.tsx

+};
+
+// accept config attributes
+() => <lr-config ctx-name="1" multiple multipleMax={1} multipleMin={2} accept="str" />;


types/test/lr-config.test-d.tsx

+() => <lr-config ctx-name="1" multiple multipleMax={1} multipleMin={2} accept="str" />;
+
+// allow to use DOM properties
+() => {


types/test/lr-config.test-d.tsx

+
+
+// allow to pass metadata
+() => {


types/test/lr-config.test-d.tsx

+  const ref = React.useRef<Config | null>(null);
+  if (ref.current) {
+    const config = ref.current;
+    config.metadata = {foo: 'bar'}


types/test/lr-config.test-d.tsx

+  if (ref.current) {
+    const config = ref.current;
+    config.metadata = {foo: 'bar'}
+    config.metadata = () => ({foo: 'bar'})


types/test/lr-config.test-d.tsx

+import { OutputFileEntry } from '..';
+
+// @ts-expect-error untyped props
+() => <lr-config ctx-name="1" something="wrong"></lr-config>;


nd0ut marked this pull request as draft November 1, 2023 13:39

nd0ut changed the title ~~WIP~~ Emit events on lr-upload-ctx-provider block Nov 1, 2023

nd0ut force-pushed the feat/events-on-ctx-block branch from 2d5a6c4 to eb77a36 Compare November 3, 2023 13:16

github-advanced-security bot found potential problems Nov 3, 2023

View reviewed changes

nd0ut force-pushed the feat/events-on-ctx-block branch from eb77a36 to 912ed77 Compare November 7, 2023 08:26

github-advanced-security bot found potential problems Nov 7, 2023

View reviewed changes

nd0ut marked this pull request as ready for review November 7, 2023 08:59

nd0ut force-pushed the feat/events-on-ctx-block branch from a089d76 to b30cee5 Compare November 7, 2023 09:18

nd0ut added 2 commits November 7, 2023 12:39

feat: move global events to the lr-upload-ctx-provider scope

c452eeb

chore: disable codeql for type tests

2c65b7d

nd0ut force-pushed the feat/events-on-ctx-block branch from 3df68db to 2c65b7d Compare November 7, 2023 09:39

loookashow self-requested a review November 8, 2023 09:04

loookashow approved these changes Nov 9, 2023

View reviewed changes

nd0ut merged commit 2beae73 into main Nov 9, 2023
1 check passed

nd0ut deleted the feat/events-on-ctx-block branch November 9, 2023 15:28


		const ctx: UploadCtxProvider = null as unknown as UploadCtxProvider;

		ctx.addEventListener('data-output', (e) => {