Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add missing LR_CLOUD_MODIFICATION JSX type #542

Merged
merged 1 commit into from
Oct 19, 2023
Merged

fix(types): add missing LR_CLOUD_MODIFICATION JSX type #542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion abstract/EventManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export const EVENT_TYPES = {
UPLOAD_FINISH: 'UPLOAD_FINISH',
UPLOAD_ERROR: 'UPLOAD_ERROR',
VALIDATION_ERROR: 'VALIDATION_ERROR',
CDN_MODIFICATION: 'CLOUD_MODIFICATION',
CLOUD_MODIFICATION: 'CLOUD_MODIFICATION',
DATA_OUTPUT: 'DATA_OUTPUT',
DONE_FLOW: 'DONE_FLOW',
INIT_FLOW: 'INIT_FLOW',
Expand Down
4 changes: 2 additions & 2 deletions abstract/UploaderBlock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import { Data } from '@symbiotejs/symbiote';
import { calculateMaxCenteredCropFrame } from '../blocks/CloudImageEditor/src/crop-utils.js';
import { parseCropPreset } from '../blocks/CloudImageEditor/src/lib/parseCropPreset.js';
import { Modal } from '../blocks/Modal/Modal.js';

Check warning on line 7 in abstract/UploaderBlock.js

View workflow job for this annotation

GitHub Actions / build 

'Modal' is defined but never used
import { UploadSource } from '../blocks/utils/UploadSource.js';
import { debounce } from '../blocks/utils/debounce.js';
import { customUserAgent } from '../blocks/utils/userAgent.js';
Expand Down Expand Up @@ -524,7 +524,7 @@
items.forEach((id) => {
EventManager.emit(
new EventData({
type: EVENT_TYPES.CDN_MODIFICATION,
type: EVENT_TYPES.CLOUD_MODIFICATION,
ctx: this.ctxName,
data: Data.getCtx(id).store,
}),
Expand Down Expand Up @@ -666,7 +666,7 @@
const cb = debounce(
/** @param {CustomEvent} e */
(e) => {
let outputTypes = [EVENT_TYPES.UPLOAD_FINISH, EVENT_TYPES.REMOVE, EVENT_TYPES.CDN_MODIFICATION];
let outputTypes = [EVENT_TYPES.UPLOAD_FINISH, EVENT_TYPES.REMOVE, EVENT_TYPES.CLOUD_MODIFICATION];
// @ts-ignore TODO: fix this
if (outputTypes.includes(e.detail.type)) {
// @ts-ignore TODO: fix this
Expand Down
2 changes: 1 addition & 1 deletion types/events.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ interface CustomEventMap {
UPLOAD_FINISH: CustomEvent<any>;
UPLOAD_ERROR: CustomEvent<any>;
VALIDATION_ERROR: CustomEvent<any>;
CDN_MODIFICATION: CustomEvent<any>;
CLOUD_MODIFICATION: CustomEvent<any>;
DATA_OUTPUT: CustomEvent<any>;
DONE_FLOW: CustomEvent<any>;
INIT_FLOW: CustomEvent<any>;
Expand Down
Loading