feat(a11y): added zIndex if it wasn't there

uploadcare · Jun 17, 2024 · ff58dd8 · ff58dd8
1 parent 96194a7
commit ff58dd8
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 10 deletions.
diff --git a/blocks/CloudImageEditor/src/EditorButtonControl.js b/blocks/CloudImageEditor/src/EditorButtonControl.js
@@ -16,10 +16,9 @@ export class EditorButtonControl extends Block {
     this._titleEl = this.ref['title-el'];
     this._iconEl = this.ref['icon-el'];
 
-    // this.setAttribute('role', 'button');
-    // if (this.tabIndex === -1) {
-    //   this.tabIndex = 0;
-    // }
+    if (this.firstElementChild.tabIndex === -1) {
+      this.firstElementChild.tabIndex = 0;
+    }
 
     this.sub('title', (title) => {
       let titleEl = this._titleEl;

diff --git a/blocks/CloudImageEditor/src/EditorToolbar.js b/blocks/CloudImageEditor/src/EditorToolbar.js
@@ -104,8 +104,6 @@ export class EditorToolbar extends Block {
       /** @param {MouseEvent} e */
       'on.clickTab': (e) => {
         const id = /** @type {HTMLElement} */ (e.currentTarget).getAttribute('data-id');
-
-        console.log({ id });
         if (id) {
           this._activateTab(id, { fromViewer: false });
         }

diff --git a/blocks/CloudImageEditor/src/elements/button/LrBtnUi.js b/blocks/CloudImageEditor/src/elements/button/LrBtnUi.js
@@ -54,10 +54,9 @@ export class LrBtnUi extends Block {
       this._iconSingle = false;
     });
 
-    // this.setAttribute('role', 'button');
-    // if (this.tabIndex === -1) {
-    //   this.tabIndex = 0;
-    // }
+    if (this.firstElementChild.tabIndex === -1) {
+      this.firstElementChild.tabIndex = 0;
+    }
     if (!this.hasAttribute('theme')) {
       this.setAttribute('theme', 'default');
     }