fix(cloud-image-editor): little memory leak where cloud image editor …

…was holding some references that prevents from context destroying
uploadcare · Aug 7, 2024 · 70a9b2b · 70a9b2b
1 parent ef663fa
commit 70a9b2b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/abstract/Block.js b/abstract/Block.js
@@ -209,6 +209,8 @@ export class Block extends BaseComponent {
 
   /** @protected */
   destroyCallback() {
+    super.destroyCallback();
+
     let blocksRegistry = this.blocksRegistry;
     blocksRegistry?.delete(this);
 

diff --git a/blocks/CloudImageEditor/src/elements/slider/SliderUi.js b/blocks/CloudImageEditor/src/elements/slider/SliderUi.js
@@ -163,6 +163,7 @@ export class SliderUi extends Block {
   }
 
   destroyCallback() {
+    super.destroyCallback();
     this._observer?.disconnect();
   }
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -163,6 +163,7 @@ export class SliderUi extends Block { @@
       }
       destroyCallback() {
+        super.destroyCallback();
         this._observer?.disconnect();
       }
     }
@@ Expand Down @@