feat: added titles a11y in buttons of uc-activity-header

uploadcare · Oct 4, 2024 · 6827b7c · 6827b7c
1 parent d0bb581
commit 6827b7c
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 9 deletions.
diff --git a/blocks/CameraSource/CameraSource.js b/blocks/CameraSource/CameraSource.js
@@ -215,7 +215,7 @@ export class CameraSource extends UploaderBlock {
 
 CameraSource.template = /* HTML */ `
   <uc-activity-header>
-    <button type="button" class="uc-mini-btn" set="onclick: *historyBack">
+    <button type="button" class="uc-mini-btn" set="onclick: *historyBack" l10n="@title:back">
       <uc-icon name="back"></uc-icon>
     </button>
     <div set="@hidden: !cameraSelectHidden">
@@ -227,7 +227,12 @@ CameraSource.template = /* HTML */ `
       set="$.options: cameraSelectOptions; @hidden: cameraSelectHidden; onchange: onCameraSelectChange"
     >
     </uc-select>
-    <button type="button" class="uc-mini-btn uc-close-btn" set="onclick: *closeModal">
+    <button
+      type="button"
+      class="uc-mini-btn uc-close-btn"
+      set="onclick: *closeModal"
+      l10n="@title:a11y-activity-header-button-close"
+    >
       <uc-icon name="close"></uc-icon>
     </button>
   </uc-activity-header>

diff --git a/blocks/ExternalSource/ExternalSource.js b/blocks/ExternalSource/ExternalSource.js
@@ -249,14 +249,19 @@ export class ExternalSource extends UploaderBlock {
 
 ExternalSource.template = /* HTML */ `
   <uc-activity-header>
-    <button type="button" class="uc-mini-btn" set="onclick: *historyBack">
+    <button type="button" class="uc-mini-btn" set="onclick: *historyBack" l10n="@title:back">
       <uc-icon name="back"></uc-icon>
     </button>
     <div>
       <uc-icon set="@name: activityIcon"></uc-icon>
       <span>{{activityCaption}}</span>
     </div>
-    <button type="button" class="uc-mini-btn uc-close-btn" set="onclick: *historyBack">
+    <button
+      type="button"
+      class="uc-mini-btn uc-close-btn"
+      set="onclick: *historyBack"
+      l10n="@title:a11y-activity-header-button-close"
+    >
       <uc-icon name="close"></uc-icon>
     </button>
   </uc-activity-header>

diff --git a/blocks/Icon/Icon.js b/blocks/Icon/Icon.js
@@ -9,7 +9,6 @@ export class Icon extends Block {
       ...this.init$,
       name: '',
       href: '',
-      title: '',
     };
   }
 
@@ -33,12 +32,10 @@ export class Icon extends Block {
 
 Icon.template = /* HTML */ `
   <svg ref="svg" xmlns="http://www.w3.org/2000/svg">
-    <title>{{title}}</title>
     <use set="@href: href;"></use>
   </svg>
 `;
 
 Icon.bindAttributes({
   name: 'name',
-  title: 'title',
 });
diff --git a/blocks/UrlSource/UrlSource.js b/blocks/UrlSource/UrlSource.js
@@ -38,14 +38,19 @@ export class UrlSource extends UploaderBlock {
 
 UrlSource.template = /* HTML */ `
   <uc-activity-header>
-    <button type="button" class="uc-mini-btn" set="onclick: *historyBack">
+    <button type="button" class="uc-mini-btn" set="onclick: *historyBack" l10n="@title:back">
       <uc-icon name="back"></uc-icon>
     </button>
     <div>
       <uc-icon name="url"></uc-icon>
       <span l10n="caption-from-url"></span>
     </div>
-    <button type="button" class="uc-mini-btn uc-close-btn" set="onclick: *closeModal">
+    <button
+      type="button"
+      class="uc-mini-btn uc-close-btn"
+      set="onclick: *closeModal"
+      l10n="@title:a11y-activity-header-button-close"
+    >
       <uc-icon name="close"></uc-icon>
     </button>
   </uc-activity-header>