Tfenv support #82
Closed
Tfenv support #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ytsarev
reviewed
Feb 22, 2023
| @@ -568,7 +568,7 @@ func TestConnect(t *testing.T) { | |||
| }, | |||
| usage: resource.TrackerFn(func(_ context.Context, _ resource.Managed) error { return nil }), | |||
| fs: afero.Afero{Fs: afero.NewMemMapFs()}, | |||
| terraform: func(_ string) tfclient { | |||
| terraform: func(_ string, _ ...string) tfclient { | |||
There was a problem hiding this comment.
Can we add a dedicated test that would check the environment propagation?
| && chmod +x /usr/local/bin/terraform \ | ||
| RUN git clone https://github.com/tfutils/tfenv.git /opt/tfenv \ | ||
| && ln -s /opt/tfenv/bin/* /usr/local/bin \ | ||
| && tfenv use 1.3.7 \ |
There was a problem hiding this comment.
is it intentional we use this exact hardcoded version here?
|
|
1 task
|
At this point in time, we will not allow overriding the Terraform binary with the possibility of one released after 1.5.x as they are released under the BSL license. This provider would violate the license terms, and we do not want to open the possibility for that even if the action was taken by a user of the provider. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds support for
tfenv. The addition oftfenvallows a user to optionally decouple the version of Terraform from the provider image, if we choose or need to do so. If left alone, the previous behavior is preserved (you get the version which ships with the image)This allows flexibility in that: we can choose the version of Terraform, and the version of the provider independently, should we choose to do so.
Decoupling of versions: The Terraform Interface is "relatively" stable now -
tfenvwould allow us to no longer require a specific version of the provider if we want to use a newer/older version of Terraform in my environment. HC decoupled the execution layer (TF) from the control layer very long ago and it dramatically improved the developer experience and the speed of development.Enterprise requirements: we test our TF code & modules against specific versions of Terraform and specific versions of TF providers, we want to ensure that we can implement these requirements on the execution layer (Crossplane TF provider).
@DanielRis