Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented logic for posting and rendering Markdown Content - #11 #78

Merged
merged 8 commits into from
Oct 28, 2023
Merged

Implemented logic for posting and rendering Markdown Content - #11 #78

merged 8 commits into from
Oct 28, 2023

Conversation

mehsheed
Copy link
Contributor

  • Decoded and encoded binary markdown data
  • Implemented logic for updating content_type for Markdown content posts
  • Used MuiMarkdown library and components for rendering Markdown content
  • (TODO) Change checkbox to switch
  • Screenshot 2023-10-27 040941

Thanks to @kaynzhel for implementing some last-minute bug fixes.

@mehsheed mehsheed added the Project Part 1 Track Project Part 1 User Stories label Oct 27, 2023
@mehsheed mehsheed self-assigned this Oct 27, 2023
nluu175
nluu175 approved these changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@nluu175 nluu175 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

kaynzhel
kaynzhel approved these changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@kaynzhel kaynzhel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one small nit to remove console loggin, otherwise lgtm

client/src/components/post/MakePostModal.tsx Outdated Show resolved Hide resolved
Boredalien248
Boredalien248 approved these changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@Boredalien248 Boredalien248 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mehsheed mehsheed merged commit 2d4453c into main Oct 28, 2023
@mehsheed mehsheed deleted the 11-commonmark-latest branch October 28, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boredalien248 Boredalien248 Boredalien248 approved these changes

@nluu175 nluu175 nluu175 approved these changes

@kaynzhel kaynzhel kaynzhel approved these changes

@rmgutierrez rmgutierrez Awaiting requested review from rmgutierrez

Assignees

@mehsheed mehsheed

Labels
Project Part 1 Track Project Part 1 User Stories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mehsheed @kaynzhel @nluu175 @Boredalien248