Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added author_id to login response and methods to store and retrieve a… #61

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

nluu175
Copy link
Contributor

@nluu175 nluu175 commented Oct 24, 2023

  • Added author_id as a field to Reponse data on successful login.
  • Added a methods to store and retrieve author_id to/from localStorage.

Expected behaviour:

  • A new author_id field is stored in localStorage on successful login.
  • author_id of the current user can be retrieved from the localStorage using getAuthorId that can be found in utils/localStorageUtils.ts

How to test:

  • Check whether the author_id of the current logged in user has the same id with the one in database.

@nluu175 nluu175 requested a review from kaynzhel October 24, 2023 21:39
Copy link
Contributor

@kaynzhel kaynzhel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, QA'ed with replacing one of the hardcoded AUTHOR_ID and it matches the uuid of the logged in user

@kaynzhel kaynzhel merged commit 5b7883a into main Oct 24, 2023
@kaynzhel kaynzhel deleted the retrieve-author-id branch October 24, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants