24 user profile #60
Merged
24 user profile #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g on project name navigates back to home
FOR TESTING :
|
kaynzhel
reviewed
Oct 24, 2023
Comment on lines
+104
to
+112
| <AppBar position="relative"> | ||
| <Toolbar> | ||
| <Link to="/home-page"> | ||
| <Typography variant="h6" className={classes.customLink} style={{ textDecoration: 'none' }}> | ||
| SocialDistribution | ||
| </Typography> | ||
| </Link> | ||
| </Toolbar> | ||
| </AppBar> |
There was a problem hiding this comment.
Don't need to do for this PR: I see that home page and profile page have different app bars, I'll add an issue to create a header component to have them be consistent.
Comment on lines
+21
to
+26
| def get(self, request, author_id): | ||
| # get the author data whose id is AUTHOR_ID | ||
| author = Author.objects.get(id=author_id) | ||
| serializer = AuthorSerializer(author) | ||
| return Response(serializer.data, status=status.HTTP_200_OK) | ||
|
|
There was a problem hiding this comment.
Can be done later on but the api needs to have an updated serializer. On the project reqs, a call to a single author has "type", has an id url for the id field instead of the uuid, etc..
I don't think it's needed for this profile page, so this can be updated as we work more on these api calls.
kaynzhel
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React.App.-.Google.Chrome.2023-10-24.14-43-02.mp4