-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
24 user profile #58
24 user profile #58
Conversation
Boredalien248
commented
Oct 23, 2023
- Just laid out a basic design for the profile page
- added some more dependencies please run npm install before starting
- let me know if i missed anything
@Boredalien248 please add screenshots so that we can see what's happening at your end and compare it with ours if any discrepancies. Thanks! |
</CardMedia> | ||
<CardContent> | ||
<Typography variant="h5">What is Lorem Ipsum?</Typography> | ||
<Typography>Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type and scrambled it to make a type specimen book. It has survived not only five centuries, but also the leap into electronic typesetting, remaining essentially unchanged. It was popularised in the 1960s with the release of Letraset sheets containing Lorem Ipsum passages, and more recently with desktop publishing software like Aldus PageMaker including versions of Lorem Ipsum.</Typography> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove place holder text from those lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove place holder text from client/src/components/ProfilePage.tsx
client/package.json
Outdated
@@ -5,8 +5,10 @@ | |||
"dependencies": { | |||
"@emotion/react": "^11.11.1", | |||
"@emotion/styled": "^11.11.0", | |||
"@material-ui/core": "^4.12.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the deprecated version for material-ui, you can just just use the styles in mui. I think it'd be best if we stick with one version, so I think we can uninstall this one. Thoughts?
import { makeStyles } from "@material-ui/core/styles"; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update:
import { makeStyles } from "@material-ui/core/styles"; | |
import { makeStyles } from "@mui/styles"; | |
Then, it'll give you a warning on theme.spacing
, please add the code from here on our index.tsx
file. Thank you!
Sorry about that. For now the profile page should look like the image provided below. |
removed the deprecated version and the placeholders. |