Part 2 UI bug-fixes/enhancements

[rmgutierrez]

Major

Problem: Found out that unlisted posts are still sent to followers because they are technically PUBLIC posts, but unlisted was never checked.

• Fix: changed visibility === sharetype.PUBLIC to visibility === sharetype.PUBLIC && !unlisted when sending PUBLIC posts to follower inbox.

Problem: Author can visit another author's profile page and see their unlisted posts.

• Fix: changed post.visibility === sharetype.PUBLIC to visibility === sharetype.PUBLIC && post.unlisted == false when filtering posts to show the author.

Not a problem but I added handleAvatarClick to both PostPage and PostsList to navigate to author's profile page (More than a UI fix/enhancement)

Minor

• PostPage

  • Fixed the loading animation (it used to appear at the bottom of the screen)
  • Minimized the chip that shows whether remote or local
  • Added click to avatar to navigate to author's profile page

• PostsList

  • Also minimized the chip that shows whether remote or local
  • Also added click to avatar to navigate to author's profile page

• MakePostModal

  • Fixed the "Select a follower" input when making private posts
    • Modified its size to be more consistent with the other inputs

• Loading

  • Changed the colour of the circular progress to grey, as well as made it a bit thicker

• ProfilePage/ProfileTabs

  • Update github link format
    • Removed "https://" when rendered, removed underline, changed font weight
  • Added loading animation to profile page
  • Also added loading animations to both posts list and followers list within profile page

• SharePostModal

  • Added the text "You have no followers..." if user presses the share button and they don't have any followers

• AppBar

  • Made the sign-out button a lighter colour
  • Aligned "distributed" with the buttons on the LeftNavBar
    • Taking inspiration from Twitter (this can be changed, I'm really not sure which one looks better)
    • (My fault) Had a bug where the entire left side of "distributed" linked to home page, now fixed

• LeftNavBar

  • Added a max width to the post button
    • It grew longer for higher resolution devices

• GithubEventList

  • Added primary color to github logo and text
  • Prevent bug where the list would shift to the right when the modal is opened
    • Positioned from the left instead of the right

[kaynzhel]

lgtm