23 [Part 1]: Unfollowing a local author #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Unfollow button shows when "following" button is hovered
…hey wanna refollow again
kaynzhel
force-pushed
the
23-unfollow
branch
from
8d26129 to
1bf7480
Compare
|
rebased latest main |
|
Should we either centre "Unfollow authorName" or align both texts with each other?
|
rmgutierrez
approved these changes
Nov 23, 2023
rmgutierrez
added a commit
that referenced
this pull request
Nov 23, 2023
## Review #113 First ### Changes - Added endpoint to easily delete a `Follow` object and its corresponding `InboxItem` object - Implement declining a friend request - Declining means that it gets remove from the inbox - Adding these buttons made the rendering more noticeable, so I implement a `Loading` component to be shown when data is still being fetched. ### Example https://github.com/uofa-cmput404/404f23project-404-team-not-found/assets/40973251/d7313336-a4a9-4fce-99b3-cfc367055767 https://github.com/uofa-cmput404/404f23project-404-team-not-found/assets/40973251/4693cdfb-4a2f-449f-bafd-a2e77785268f
Merged
kaynzhel
added a commit
that referenced
this pull request
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
DeletePostModalin terms of its designFollowandInboxItemrecords since user has already unfollowed. (They can refollow again)Example (Following to unfollowing)
Screen.Recording.2023-11-20.at.1.46.01.PM.mov