Skip to content
This repository has been archived by the owner on Sep 15, 2022. It is now read-only.

Fixes issue with add model.kindOf check #11

Closed
wants to merge 1 commit into from

Conversation

zofiag
Copy link

@zofiag zofiag commented Mar 31, 2021

Fixes #10

@unstubbable
Copy link
Owner

Thanks. Do you have an example where this currently fails? I'd like to know what kind of model that is. So can you log the model for me and post the output here?

@zofiag
Copy link
Author

zofiag commented Mar 31, 2021

Sure! I think it fails when monorepo plugin is combined with https://github.com/mipatterson/typedoc-plugin-pages.

These are the keys of a problematic model: [ 'url', 'model', 'template', 'parent', 'name', 'pagesPlugin' ] (the whole object was huge, hope the keys list is enough).

My dependencies:

 "devDependencies": {
    "typedoc-plugin-monorepo": // currently link to a fork,
    "typedoc": "^0.20.34",
    "typedoc-plugin-pages": "^1.1.0"
  },

@edqx
Copy link

edqx commented Apr 21, 2021

Is it possible that this could be merged or looked at again? I could do with this for a project and I'm currently running a submodule of my fork with this pr merged into it, not really ideal. using yarn patch to manually patch code on installation.

@unstubbable
Copy link
Owner

@zofiag @edqx Sorry for not looking at this earlier. ... I tried to test this PR along with typedoc-plugin-pages (actually typedoc-plugin-pages-fork because of mipatterson/typedoc-plugin-pages#41). I'm wondering whether you even want to use the TOC plugin that is included in typedoc-plugin-monorepo. In my testing this created duplicate TOC entries for the modules, because apparently typedoc-plugin-pages also creates those TOC entries.

Screenshot 2021-04-23 at 10 17 18

@edqx
Copy link

edqx commented Apr 23, 2021

Removing typedoc-plugin-monorepo led to this.. Although I'm actually not sure what you mean by TOC, and how I can disable that.
image

@edqx
Copy link

edqx commented Apr 23, 2021

I see, the toc plugin modifies the table of contents at the side of every page. Still not sure how I can disable it though, as using asgerjensen/typedoc-plugin-external-module-map didn't work for me, only one of my packages showed up.

@unstubbable
Copy link
Owner

This project is deprecated since TypeDoc now supports monorepos out of the box.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It almost worked model.kindof is not a function
3 participants