Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traitlet error removal #870

Merged
merged 7 commits into from
Sep 15, 2023
Merged

Traitlet error removal #870

merged 7 commits into from
Sep 15, 2023

Conversation

jayasimha-raghavan-unskript
Copy link
Member

@jayasimha-raghavan-unskript jayasimha-raghavan-unskript commented Sep 15, 2023

Description

EN-5056
This PR brings in the fix that cleans up the Notebook Node before creating the temporary runbook
that gets run.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Cleaned up debugs and redundant display of results

Screen.Recording.2023-09-15.at.10.34.45.AM.mov

Checklist:

  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published.

Documentation

Make sure that you have documented corresponding changes in this repository.

@jayasimha-raghavan-unskript jayasimha-raghavan-unskript marked this pull request as draft September 15, 2023 17:54
@jayasimha-raghavan-unskript jayasimha-raghavan-unskript marked this pull request as ready for review September 15, 2023 19:16
@amit-chandak-unskript amit-chandak-unskript merged commit 6aa72c3 into master Sep 15, 2023
7 checks passed
@amit-chandak-unskript amit-chandak-unskript deleted the en-5056-jayasimha branch September 15, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants