Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMTP Enhacement to READ Credentials from Vault server #1096

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

jayasimha-raghavan-unskript
Copy link
Member

@jayasimha-raghavan-unskript jayasimha-raghavan-unskript commented Aug 12, 2024

Description

Please include a summary of the change, motivation and context.
EN-5660

This PR Brings in support for

  • Reading SMTP credentials from Vault
  • Basic support for Office365 email sending using OAuth2

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

unskript@awesome-awesome-runbooks-0:~$ unskript-ctl.sh run check --type vault --report
Running: 100%|████████████████████████████████████████████████████████| 1/1 [00:00<00:00,  2.54it/s]

╒══════════════════════════╤══════════╤════════════════╤═════════╕
│ Checks Name              │ Result   │   Failed Count │ Error   │
╞══════════════════════════╪══════════╪════════════════╪═════════╡
│ Get Vault service health │  PASS    │              0 │ N/A     │
╘══════════════════════════╧══════════╧════════════════╧═════════╛


Fetching logs...
Error: 'checks->diagnostics' section not found in '/etc/unskript/unskript_ctl_config.yaml'.
Skipping Diagnostics: No diagnostic command found. You can define them in the YAML configuration file
Uploading run artifacts to S3...
2024-08-12 03:02:47,231 - UnskriptCtlLogger - INFO - Response OK from Vault server
2024-08-12 03:02:47,231 - UnskriptCtlLogger - INFO - SMTP Credentials successfully retrieved from Vault
2024-08-12 03:02:47,574 - UnskriptCtlLogger - INFO - Slack Message was sent successfully!
INFO:botocore.credentials:Found credentials in environment variables.
2024-08-12 03:02:48,139 - UnskriptCtlLogger - INFO - Email notification sent to [email protected]
2024-08-12 03:02:48,142 - UnskriptCtlLogger - INFO - Successfully sent Email notification via AWS SES.

Checklist:

  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published.

Documentation

Make sure that you have documented corresponding changes in this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant