Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bucket exists check before uploading to S3 #1072

Merged

Conversation

shloka-bhalgat-unskript
Copy link
Member

Description

Found an issue where the bucket existence was not being verified, so added a check to do that

Testing

Screenshot 2024-05-31 at 11 35 30 PM

Checklist:

  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published.

Documentation

Make sure that you have documented corresponding changes in this repository.

@jayasimha-raghavan-unskript jayasimha-raghavan-unskript merged commit 8efda84 into master May 31, 2024
10 checks passed
@jayasimha-raghavan-unskript jayasimha-raghavan-unskript deleted the add-bucket-exists-check-for-s3-upload branch May 31, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants