Remove fan raw value

The non-raw value works well.
unregist · Dec 23, 2024 · 723da53 · 723da53
1 parent 3d09d9e
commit 723da53
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 13 deletions.
diff --git a/esphome/components/MhiAcCtrl/MHI-AC-Ctrl-core.cpp b/esphome/components/MhiAcCtrl/MHI-AC-Ctrl-core.cpp
@@ -191,10 +191,6 @@ ACFan mhi_ac_ctrl_core_fan_get() {
     }
 }
 
-uint8_t mhi_ac_ctrl_core_fan_get_raw() {
-    return mosi_frame_snapshot[DB1] & FAN_MASK;
-}
-
 bool mhi_ac_ctrl_core_current_temperature_changed() {
     return mosi_frame_snapshot[DB3] != mosi_frame_snapshot_prev[DB3];
 }

diff --git a/esphome/components/MhiAcCtrl/MHI-AC-Ctrl-core.h b/esphome/components/MhiAcCtrl/MHI-AC-Ctrl-core.h
@@ -102,7 +102,6 @@ ACMode mhi_ac_ctrl_core_mode_get();
 bool mhi_ac_ctrl_core_fan_changed();
 void mhi_ac_ctrl_core_fan_set(ACFan fan);
 ACFan mhi_ac_ctrl_core_fan_get();
-uint8_t mhi_ac_ctrl_core_fan_get_raw();
 
 bool mhi_ac_ctrl_core_current_temperature_changed();
 float mhi_ac_ctrl_core_current_temperature_get();

diff --git a/esphome/components/MhiAcCtrl/mhi_ac_ctrl.h b/esphome/components/MhiAcCtrl/mhi_ac_ctrl.h
@@ -292,8 +292,6 @@ class MhiAcCtrl : public climate::Climate,
                 default:
                     break;
             }
-            if(fan_raw_sensor_)
-                fan_raw_sensor_->publish_state(mhi_ac_ctrl_core_fan_get_raw());
         }
 
         if(climate_current_temperature_sensor_) {
@@ -427,7 +425,6 @@ class MhiAcCtrl : public climate::Climate,
     const float temperature_step_ { 1.0f };
     const std::string custom_fan_ultra_low = std::string("Ultra Low");
 
-    SUB_SENSOR(fan_raw)
     SUB_SENSOR(climate_current_temperature)
 
 protected:

diff --git a/esphome/components/MhiAcCtrl/sensor.py b/esphome/components/MhiAcCtrl/sensor.py
@@ -16,12 +16,10 @@
 from . import MhiAcCtrl, CONF_MHI_AC_CTRL_ID
 
 CONF_FRAME_ERRORS = "frame_errors"
-CONF_FAN_RAW = "fan_raw"
 CONF_TOTAL_ENERGY = "total_energy"
 CONF_CLIMATE_CURRENT_TEMPERATURE = "climate_current_temperature"
 
 TYPES = [
-    CONF_FAN_RAW,
     CONF_TOTAL_ENERGY,
     CONF_POWER,
     CONF_FRAME_ERRORS,
@@ -37,7 +35,6 @@
         {
             cv.GenerateID(): cv.declare_id(MhiAcCtrl),
             cv.GenerateID(CONF_MHI_AC_CTRL_ID): cv.use_id(MhiAcCtrl),
-            cv.Optional(CONF_FAN_RAW): sensor.sensor_schema(icon=ICON_FAN),
             cv.Optional(CONF_TOTAL_ENERGY): sensor.sensor_schema(
                 class_=MhiTotalEnergy,
                 unit_of_measurement=UNIT_WATT_HOURS,

diff --git a/esphome/example.yaml b/esphome/example.yaml
@@ -50,8 +50,6 @@ select:
 sensor:
   - platform: MhiAcCtrl
     mhi_ac_ctrl_id: ${mhi_device_id}
-    fan_raw:
-      name: ${device_name} fan raw
     total_energy:
       name: ${device_name} Energy
       filters: