Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: sidebar:state save in localStorage #889

Closed
wants to merge 1 commit into from

Conversation

matinsoleymni
Copy link

@matinsoleymni matinsoleymni commented Nov 11, 2024

πŸ”— Linked issue

no issue :)

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

In my personal project, I was using a sidebar, but since it relied on cookies, it took a bit of time to update. To improve the update speed of the sidebar’s status, I switched it to use localStorage. There was no issue opened for this, but I wanted to submit a PR to enhance performance. :)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@zernonia
Copy link
Member

We want to use cookie to prevent layout shift on mount. You are free to switch your local code to use localStorage. Thus I'm closing this 😁

@zernonia zernonia closed this Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants