Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(example): fix dialog-form onsubmit #873

Merged
merged 2 commits into from
Nov 9, 2024

Conversation

rhanlin
Copy link
Contributor

@rhanlin rhanlin commented Nov 9, 2024

πŸ”— Linked issue

close 872

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

  1. Add the form’s id to make sure the correct form responds when the submit button is clicked.
  2. According to vee-validate’s documentation on handling forms, submitForm causes the page to "reload," so use handleSubmit instead to handle form submission.

πŸ“Έ Screenshots (if appropriate)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@sadeghbarati
Copy link
Collaborator

Thanks ❀️

Since it's related to the docs, will mark the commit as docs:

@sadeghbarati sadeghbarati merged commit 3d0db2d into unovue:dev Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: In dialog-form example, onSubmit failed.
2 participants