-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement new Tasks BigData
example for useVirtualList usage
#334
base: dev
Are you sure you want to change the base?
feat: implement new Tasks BigData
example for useVirtualList usage
#334
Conversation
Thanks, Man! @romanhrynevych Will try to checkout to your branch to fully test it ❤️ Also, I think the issue you linked is related to
Can you explain more please 🙏 |
Don't think that this place on main page is great position for example, maybe you will move it to another place 😁❤️ |
I think in |
@zernonia can you take a look on this PR? What you think is the best place to show Tasks Example? |
Thanks for the PR @romanhrynevych . I don't think we need to duplicate a whole other component just to showcase large dataset. Most of the component/utilities are the same and can be reuse from And let's create another path (https://www.shadcn-vue.com/docs/guide/rendering-large-data.html), and write some guide/steps to help other dev to use the virtualisation package instead of another demo. I believe this way it will be more clear, and more helpful. |
Ok, I will update this PR to your advice soon ❤️ |
@sadeghbarati hi 👋 I added new If it will be some more fixes feel free to provide them, i will fix all of them 😁 |
Thanks Roman will check |
@sadeghbarati just noticed that tanstack has his own virtualizer (noticed in this Radix-vue Issue your comment 😁 ) unovue/radix-vue#696 (comment), maybe here I will replace vueuse integration with tanstack table example? Link: https://tanstack.com/virtual/latest/docs/framework/vue/examples/table |
Feel free to switch to TanStack Virtual or add both? |
thinking about switching to TanStack for more extended features in future 🤔 |
Yes TanStack for the Win |
I've found tanstack virtualized more difficult to use (and finnicky) than vue-use, but vue-use has less features Coudln't really manage to make this work with a table without hitting display issues, so I ended up adding fixed-width to all cells and using a "list" with each row made of cells |
This PR try to fix #296
So I add a new example where implemented
virtualList
based on vueuse core function.I tried to use seperate package but it don't fit for
table
HTML at all because creating 2 div wrappers.Please watch this video 👇 , or try by yourself, you will feel performance improvements at all
big-data-example.mp4
@sadeghbarati need help with this, what will be the best Doc for this, because if we are porting only original package, there is no
BigData
example at all 🙂