fix(DateField): Fixed segement initialization in DateField parser util to not include… #1450
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… certain segments when granularity is set to minute or hour
TristanMNorton
changed the title
TristanMNorton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed a bug when using DateField, or other components that leverage DateField such as DatePicker where the modelValue wouldn't update appropriately when fully entered if granularity is set to
minuteorhour.When setting granularity to
minutefor instance, the DateField's parser util still includessecondas a segment when usinginitializeSegmentValues. This preventshandleSegmentKeydownfrom ever setting the modelValue since there's always at least one null value.Happy to adjust this change based on any feedback.