Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initialize Windows localSelection (backport #2457) #2501

Open
wants to merge 2 commits into
base: release/stable/4.2
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Aug 6, 2024

GitHub Issue (If applicable): closes #2473

PR Type

What kind of change does this PR introduce?

  • Bugfix

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):


This is an automatic backport of pull request #2457 done by [Mergify](https://mergify.com).

(cherry picked from commit 724d6e1)
(cherry picked from commit 119b71b)
@mergify mergify bot mentioned this pull request Aug 6, 2024
7 tasks
@kazo0
Copy link
Contributor

kazo0 commented Aug 8, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kazo0 kazo0 enabled auto-merge August 8, 2024 12:57
@kazo0
Copy link
Contributor

kazo0 commented Sep 6, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kazo0
Copy link
Contributor

kazo0 commented Sep 11, 2024

@rajamatt I'm not understanding why those tests are failing for this PR.

Did we miss an earlier backport that fixes these or something?

@rajamatt
Copy link
Contributor

rajamatt commented Sep 11, 2024

@rajamatt I'm not understanding why those tests are failing for this PR.

Did we miss an earlier backport that fixes these or something?

@kazo0 I can see that out of two of the related failing tests, one is pretty much directly related to these changes in this PR:

Out of range exception, most probably will keep failing. I'm having trouble building the Uno.Extensions.RuntimeTests project though, which is keeping me from running tests locally. I'll post for help if I can't get it working

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants