Replacing custom interface with stock openzeppelin IERC721.sol

[nfurfaro]

Description

As per the title.

• changed IPublicLock.sol to abstract prevent compilation errors
• modified a few functions' visibility from external to public to prevent compilation errors
• added 2 getter functions (ownerOf and totalSupply) and changed existing to ownerOf and _totalSupply tp prevent duplicate declaration error.
• added one extra check in function ownerOf based on the openzeppelin implementation of the same function.

Issues

Fixes #
Refs #

Checklist:

• 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • This PR only contains configuration changes (package.json, etc.)
  • This PR only contains code changes (if configuration changes are required, do a separate PR first, then re-base)
• My code follows the style guidelines of this project, including naming conventions
• I have commented my code, particularly in hard-to-understand areas
• I have added tests that prove my fix is effective or that my feature works
• If my code adds or changes components, I have written corresponding stories with Storybook
• I have performed a self-review of my own code
• If my code involves visual changes, I am adding applicable screenshots to this thread

[HardlyDifficult]

Tests are really not happy right now ;)

[nfurfaro]

Huh. maybe something going on with solium... indentation looks fine to me. Will see if I can make it happy again.

[HardlyDifficult]

Huh. maybe something going on with solium... indentation looks fine to me. Will see if I can make it happy again.

Note that both the tests AND lint are failing.

[nfurfaro]

yeah, will look into this. The tests passed locally, will see if I can repro and sort it out.

[HardlyDifficult]

This can be closed, right? Was replaced by another PR - re-open if I missed something.

[nfurfaro]

Reopening as I have this working locally now.

[HardlyDifficult]

Sorry about that, at a glance I thought #5383 replaced this.

Let me know once it's ready for review

[nfurfaro]

@NickCuso When you have time could you give this a look over? thx

[nfurfaro]

Ha! well, that didn't work.

[HardlyDifficult]

heh yea didn't mean to complicate things :) i don't feel strongly either way if you want to revert to what you had

[nfurfaro]

I will revert the last commit which switched from internal to private. I think the rest should be good.

[nfurfaro]

ok, reverted to my earlier PR.

[nfurfaro]

@NickCuso If you're ok with the approach, I'd like to merge this. We can certainly look at further tweaks later, but right now the small changes discussed above break so many tests, I'm not sure the value is there in pursuing them atm.