Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add OTP blog, updates tags, fix image code #1933

Merged
merged 12 commits into from
Jul 18, 2024
Merged

Conversation

perkinsjr
Copy link
Collaborator

What does this PR do?

  1. Adds OTP blog
  2. Changes engineering tags to tutorials for actual tutorials
  3. Allows alt to be used and also unoptimized when needed for example a gif that can't be optimized

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

N/A

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

Copy link

vercel bot commented Jul 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 5:57pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
dashboard ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2024 5:57pm
planetfall ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2024 5:57pm
play ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2024 5:57pm
workflows ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2024 5:57pm

Copy link

changeset-bot bot commented Jul 18, 2024

⚠️ No Changeset found

Latest commit: 4d92db2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 18, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Collaborator

Needs an intro explaining the acronym OTP imo

Copy link
Collaborator

Some code snippets use snake_case

Copy link
Collaborator

Otherwise very 👌

Copy link
Collaborator

lol did you really change to kebab-case?

Copy link
Collaborator

That won’t even run now 😅

Copy link
Collaborator Author

Fixed.

Copy link
Collaborator Author

Before we merge I need to update the OG image

Copy link
Collaborator

I just approved, nothing else 🙂

Copy link
Collaborator

yeet it when you are ready

@perkinsjr perkinsjr merged commit 2c0bb6c into main Jul 18, 2024
25 checks passed
@perkinsjr perkinsjr deleted the ratelimit-otp-post branch July 18, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants