fix(metrics.go): remove "key" label from RatelimitPushPullEvents and

RatelimitPushPullLatency histograms fix(sync_with_origin.go): remove "key" label from prometheus labels in syncWithOrigin function
unkeyed · Aug 6, 2024 · 1112399 · 1112399
1 parent 36e988a
commit 1112399
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/apps/agent/pkg/prometheus/metrics.go b/apps/agent/pkg/prometheus/metrics.go
@@ -66,11 +66,11 @@ var (
 		Namespace: "agent",
 		Subsystem: "ratelimit",
 		Name:      "pushpull_events",
-	}, []string{"nodeId", "key", "peerId"})
+	}, []string{"nodeId", "peerId"})
 	RatelimitPushPullLatency = promauto.NewHistogramVec(prometheus.HistogramOpts{
 		Namespace: "agent",
 		Subsystem: "ratelimit",
 		Name:      "pushpull_latency",
 		Help:      "Latency of push/pull events in seconds",
-	}, []string{"nodeId", "key", "peerId"})
+	}, []string{"nodeId", "peerId"})
 )
diff --git a/apps/agent/services/ratelimit/sync_with_origin.go b/apps/agent/services/ratelimit/sync_with_origin.go
@@ -87,7 +87,6 @@ func (s *service) syncWithOrigin(req syncWithOriginRequest) {
 	labels := map[string]string{
 		"nodeId": s.cluster.NodeId(),
 		"peerId": peer.Id,
-		"key":    req.key,
 	}
 	prometheus.RatelimitPushPullEvents.With(labels).Add(float64(len(req.events)))