Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: detect stackblitz using process.versions.webcontainer #63

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 14, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Improve stackblitz/webcontainer environment detection based on process.versions.webcontainer.

PS: I really hope someday soon Stackblitz standard environment variables to make us able to detect running environment easier..

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #63 (e728741) into main (25cdeec) will increase coverage by 0.06%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   82.82%   82.88%   +0.06%     
==========================================
  Files           6        6              
  Lines         262      263       +1     
  Branches       25       25              
==========================================
+ Hits          217      218       +1     
  Misses         42       42              
  Partials        3        3              
Files Changed Coverage Ξ”
src/flags.ts 100.00% <100.00%> (ΓΈ)
src/providers.ts 90.00% <100.00%> (+0.07%) ⬆️

@pi0 pi0 merged commit 82c07c2 into main Aug 14, 2023
4 checks passed
@pi0 pi0 deleted the feat/stackblitz-provider-proc branch August 14, 2023 09:54
@pi0 pi0 mentioned this pull request Aug 16, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants