Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ckolos/ckolos #88

Closed
wants to merge 4 commits into from
Closed

Ckolos/ckolos #88

wants to merge 4 commits into from

Conversation

ckolos
Copy link

@ckolos ckolos commented Nov 25, 2023

Description

Checklist

  • All new and existing tests pass.
  • Rather than adding functions to fzf-zsh-plugin.zsh, I have created standalone scripts in bin so they can be used by non-ZSH users too.
  • Any scripts added use #!/usr/bin/env interpreter instead of potentially platform-specific direct paths (#!/bin/sh is an ok exception)
  • Scripts are marked executable
  • Scripts do not have a language file extension unless they are meant to be sourced and not run standalone. No one should have to know if a script was written in bash, python, ruby or whatever. Not including file extensions makes it easier to rewrite the script in another language later without having to change every reference to the previous version.
  • I have confirmed that the link(s) in my PR are valid.
  • I have read the CONTRIBUTING document.

License Acceptance

  • This repository is Apache version 2.0 licensed (some scripts may have alternate licensing inline in their code) and by making this PR, I am contributing my changes to the repository under the terms of the Apache 2 license.

@ckolos
Copy link
Author

ckolos commented Nov 25, 2023

sorry disregard.

@ckolos ckolos closed this Nov 25, 2023
@ckolos ckolos deleted the ckolos/ckolos branch November 25, 2023 19:54
@ckolos ckolos restored the ckolos/ckolos branch November 25, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant