CHANGE #831: Allow accounts with Dev level to see error #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiiMiyo
changed the title
NiiMiyo
reviewed
Oct 1, 2024
| @@ -86,7 +86,7 @@ public static Response buildResponse(ThrowingConsumer<Response> completionHandle | |||
| } | |||
| } else { | |||
| // unknown exception occurred | |||
| response.message = "Ocorreu um erro interno por parte do servidor." + (UserService.getInstance().isProduction() ? "" : "\n (" + e.getMessage() + ")"); | |||
| response.message = "Ocorreu um erro interno por parte do servidor." + ((UserService.getInstance().isProduction() || !UserService.getInstance().isUserDevSession()) ? "" : "\n (" + e.getMessage() + ")"); | |||
There was a problem hiding this comment.
Acho que isso faz com que os usuários ADMIN_ROLE não consigam ver as mensagens de erro. Precisaria trocar o nosso nível de acesso nas instâncias, é isso mesmo?
There was a problem hiding this comment.
entendi vou ajustar o nivel, pq esta admin > dev > user, o dev pode ver as mensagens de debug mas fica limitado a somente isso ai realmente precisaria ficaria mudando td tempo so pra ver os errors, acho q seria melhor dev > admin > user
NiiMiyo
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #831
Proposed Changes