Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lisp: add def{struct,type,method,class,generic,parameter} kinds and definer field #4121

Merged
merged 10 commits into from
Nov 20, 2024

Conversation

masatake
Copy link
Member

@masatake masatake commented Nov 19, 2024

Close #4120.

  • man pages for EmacsLisp and Lisp must be added.
  • introduce a data structure representing the difference between Lisp and EmacsLisp.
  • L_isdef and L_isquote should be unified.

Signed-off-by: Masatake YAMATO <[email protected]>
@aartaka
Copy link

aartaka commented Nov 19, 2024

Looks good to me!


Sorry for being so chaotic, but can you also add defparameter as the variable definer? It's the same as defvar in regards to parsing and the type of entities it creates—variables.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.89%. Comparing base (dc5edb0) to head (36181d3).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4121      +/-   ##
==========================================
+ Coverage   85.85%   85.89%   +0.03%     
==========================================
  Files         239      239              
  Lines       58654    58695      +41     
==========================================
+ Hits        50358    50416      +58     
+ Misses       8296     8279      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@masatake
Copy link
Member Author

I added the parameter/p kind. "definer:" field is for language objects tagged as unknown/Y.

@masatake masatake changed the title Lisp: add def{struct,type,method,class,generic} kinds and definer field Lisp: add def{struct,type,method,class,generic,parameter} kinds and definer field Nov 19, 2024
@aartaka
Copy link

aartaka commented Nov 19, 2024

I added the parameter/p kind.

Semantically, defparameter defines variables, as there are no parameter objects in Common Lisp. Can you use v instead?

"definer:" field is for language objects tagged as unknown/Y.

Ah, okay then.

@masatake
Copy link
Member Author

Semantically, defparameter defines variables, as there are no parameter objects in Common Lisp. Can you use v instead?

Unifying variables and parameters is the job of client tools.
ctags should provide raw information to the client tools.

@aartaka
Copy link

aartaka commented Nov 20, 2024

So be it then 👌

versionCurrent and versionAge are not updated in this commit.
They may be updated in following commits.

Signed-off-by: Masatake YAMATO <[email protected]>
@masatake masatake marked this pull request as ready for review November 20, 2024 20:10
@masatake masatake merged commit b4ca3d3 into universal-ctags:master Nov 20, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lisp: Common Lisp OOP/type parsing
2 participants