Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug fixes #926

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Minor bug fixes #926

merged 4 commits into from
Jun 21, 2024

Conversation

WrathfulSpatula
Copy link
Collaborator

@WrathfulSpatula WrathfulSpatula commented Jun 21, 2024

See my note on #914. This featured task chart display bug is significantly trickier than I expected:

  • The bug is not limited to coherence gain, if various tasks are switched into the featured task slot, but not all of them.
  • It also doesn't necessarily appear to be connected to invalid result data.
  • It raises no JavaScript or REST API error in the browser debugger.

I really don't know what the issue is, here! The long-term solution is to completely remove our dependence on Chart.js, I honestly think, as we've moved towards in 2024.

I think a temporary fix might be simply to change up the feature tasks a bit: I don't think it's less appropriate, particularly just as a temporary measure, to highlight single-qubit T1 relaxation times.

I am continuing to diagnose the issue or, ultimately, just convert our D3.js charts into some alternate optional form that works as a thumbnail. For aesthetics, though, this PR is not a bad temporary solution, I think.

Copy link
Collaborator

@vprusso vprusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@WrathfulSpatula WrathfulSpatula merged commit b4213bc into main Jun 21, 2024
2 checks passed
@WrathfulSpatula WrathfulSpatula deleted the bug_fixes branch June 21, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants