Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump marvin image version to 0.2.3 #274

Merged
merged 2 commits into from
Apr 17, 2024
Merged

bump marvin image version to 0.2.3 #274

merged 2 commits into from
Apr 17, 2024

Conversation

matheusfm
Copy link
Contributor

@matheusfm matheusfm commented Apr 17, 2024

Description

This PR bumps Marvin image version from 0.2.1 to 0.2.3.
I had only updated the version in go.mod and forgot to update the image in the last PR.

Linked Issues

UD-1367

How has this been tested?

  • Creating a custom check which uses variables. Ex:
apiVersion: zora.undistro.io/v1alpha2
kind: CustomCheck
metadata:
  name: custom-002
spec:
  message: "Required labels"
  severity: Low
  category: Custom
  match:
    resources:
      - group: ""
        version: v1
        resource: pods
  params:
    requiredLabels:
      - app
  variables:
    - expression: "'exempt' in object.metadata.labels && object.metadata.labels['exempt'] == 'true'"
      name: exempt
  validations:
    - expression: >
        variables.exempt ||
        !object.metadata.labels.all(label, 
          params.requiredLabels.all(
            req, req != label
          )
        )
      message: "Pod without required labels"

Checklist

  • I have labeled this PR with the relevant Type labels
  • I have documented my code (if applicable)
  • My changes are covered by tests

@matheusfm matheusfm added the bug 🐛 Something isn't working label Apr 17, 2024
@matheusfm matheusfm requested review from knrc and lucasjct April 17, 2024 18:31
@matheusfm matheusfm self-assigned this Apr 17, 2024
Copy link
Contributor

@lucasjct lucasjct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matheusfm, lgtm

@matheusfm matheusfm merged commit 90e798d into main Apr 17, 2024
4 checks passed
@matheusfm matheusfm deleted the bump-marvin-image branch April 17, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants