Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid updating scans schedule on helm upgrades when not explicitly set #251

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

matheusfm
Copy link
Contributor

Description

These changes avoid updates scans schedule on helm upgrades, when schedules are not set.

How has this been tested?

These changes can be tested with helm template --dry-run=server or helm upgrade --install commands in clusters without Zora installed and clusters with Zora already installed.

  • For clusters without Zora installed, the behavior should keep the same: if a scan schedule is explicitly set, use it; otherwise use a default value with 5 minutes added.
  • For clusters with Zora already installed, the schedules should not be updated unless it's explicitly set.

Checklist

  • I have labeled this PR with the relevant Type labels
  • I have documented my code (if applicable)
  • My changes are covered by tests

@matheusfm matheusfm added the enhancement New feature or request label Mar 21, 2024
@matheusfm matheusfm requested a review from knrc March 21, 2024 14:24
@matheusfm matheusfm self-assigned this Mar 21, 2024
@matheusfm matheusfm merged commit d415673 into main Mar 22, 2024
3 of 4 checks passed
@matheusfm matheusfm deleted the UD-1216 branch March 22, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants