Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix M-112 and use CEL optional values and variables in built-in checks #39

Merged
merged 4 commits into from
Mar 14, 2024

Conversation

matheusfm
Copy link
Contributor

@matheusfm matheusfm commented Mar 13, 2024

Description

This PR

Note that all built-in checks have unit tests with different cases.

Linked Issues

UD-1283

How has this been tested?

  • Running unit tests: make test
  • Scanning a cluster: go run main.go scan

Checklist

  • I have labeled this PR with the relevant Type labels
  • I have documented my code (if applicable)
  • My changes are covered by tests

@matheusfm matheusfm added the enhancement New feature or request label Mar 13, 2024
@matheusfm matheusfm requested a review from knrc March 13, 2024 19:59
@matheusfm matheusfm self-assigned this Mar 13, 2024
@matheusfm matheusfm added the bug Something isn't working label Mar 14, 2024
@matheusfm matheusfm changed the title Use CEL optional values and variables in built-in checks Fix M-112 and use CEL optional values and variables in built-in checks Mar 14, 2024
@matheusfm matheusfm merged commit 87ffbce into main Mar 14, 2024
4 checks passed
@matheusfm matheusfm deleted the feat/use-optional-values branch March 14, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants