Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CEL variables support #37

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Add CEL variables support #37

merged 5 commits into from
Mar 13, 2024

Conversation

matheusfm
Copy link
Contributor

Description

This PR add support for declaring variables with CEL in Marvin checks.
Similar to Kubernetes ValidatingAdmissionPolicy.

How has this been tested?

  • running unit tests of our built-in checks: make test
  • running a scan: go run main.go scan

Checklist

  • I have labeled this PR with the relevant Type labels
  • I have documented my code (if applicable)
  • My changes are covered by tests

@matheusfm matheusfm added the enhancement New feature or request label Mar 12, 2024
@matheusfm matheusfm requested a review from knrc March 12, 2024 15:51
@matheusfm matheusfm self-assigned this Mar 12, 2024
@matheusfm matheusfm merged commit d81464c into main Mar 13, 2024
4 checks passed
@matheusfm matheusfm deleted the UD-1275-variables-support branch March 13, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knrc knrc knrc approved these changes

Assignees

@matheusfm matheusfm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matheusfm @knrc