Add docker containers and release actions #21
Conversation
|
Solves #16, we will have to merge and create release to debug GHA |
There was a problem hiding this comment.
Is there any reason not to have a single container image with both binaries in it? They are pretty small, it gives you everything in a single image, makes the repo cleaner with a single Dockerfile.
I am pretty sure etcd, redis, mysql, mariadb, postgres, etc. all do it the same way.
|
Then your entry point will be shell and then you write nkv-server "0.0.0.0:4222" or nkv-client "127.0.0.1:2222", okay that makes sense, I'll group it all in :) Thanks, Avi! |
uncleDecart
force-pushed
the
add-docker
branch
2 times, most recently
from
9b690ae
to
11e9415
Compare
|
@deitch this too |
For more info read https://doc.rust-lang.org/cargo/faq.html#why-have-cargolock-in-version-control Signed-off-by: Pavel Abramov <[email protected]>
uncleDecart
force-pushed
the
add-docker
branch
from
11e9415
to
a279ba0
Compare
|
Rebased to master so that Cargo.lock is a valid file |
README.md
Outdated
| docker run -it --net=host uncledecart/nkv:latest ./nkv-client "4222" | ||
| ``` | ||
|
|
||
| Note that when using network different from host you might face major performance degradation, also docker |
There was a problem hiding this comment.
That is a bit harsh. Maybe tone it down?
when using network other than the host, the network implementation may impact network performance, unrelated to nkv itself.
uncleDecart
force-pushed
the
add-docker
branch
from
a279ba0
to
c12307d
Compare
Signed-off-by: Pavel Abramov <[email protected]>
It includes publishing container to DockerHub Signed-off-by: Pavel Abramov <[email protected]>
uncleDecart
force-pushed
the
add-docker
branch
from
c12307d
to
ddf4911
Compare
|
@deitch addressed the comments |
No description provided.