Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure binaries #1

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Restructure binaries #1

merged 1 commit into from
Aug 15, 2024

Conversation

deitch
Copy link
Collaborator

@deitch deitch commented Aug 14, 2024

Restructures so there is a client and a server binary, and a library for client usage.

@deitch
Copy link
Collaborator Author

deitch commented Aug 14, 2024

OK, rebased. Take a look at the structure @uncleDecart.

You can do:

  • cargo run --bin nkv-server
  • cargo run --bin nkv-client
  • cargo build for any of --lib or --bin nkv-server or --bin nkv-client

@deitch
Copy link
Collaborator Author

deitch commented Aug 14, 2024

If you like this, once this is in, we can look at implementing the server side.

@uncleDecart
Copy link
Owner

Avi, I love it! Do I get it right, that server won't run right now, I mean I can run --bin nkv-server but it won't run per se, cause there's no loop there. Also what's nkv target is for?

I think this is good and we should merge it. Next step would be to remove NATS and use either sockets or zmq. I also think that server would be beneficial in case of clustered EVE, we could synchronise between EVE instances! :D In a reliable way it'll look like synchronising between servers, why not single server instance ? Well that way it's more fault-tolerant!

I think we can put some issues to track things here. I'll do that with switching to zmq or sockets

@deitch
Copy link
Collaborator Author

deitch commented Aug 15, 2024

Correct, it fails. If you start it, it tries to connect to nats server and errors out. We can fix that next stage.

nkv target

The library. Your original example had using it as a client library. That probably will need fixing at some point, but I figure it is good enough for now.

I think this is good and we should merge it

Huzzah!

Next step would be to remove NATS and use either sockets or zmq. I also think that server would be beneficial in case of clustered EVE, we could synchronise between EVE instances! :D In a reliable way it'll look like synchronising between servers, why not single server instance ? Well that way it's more fault-tolerant!

Let's start with single-node and get it working. Then we can think about networking and clustering.

We good to merge?

@uncleDecart uncleDecart merged commit 2a971c0 into main Aug 15, 2024
1 check passed
@uncleDecart
Copy link
Owner

uncleDecart commented Aug 15, 2024

Created milestone for v.0itworks and gonna look at zmq rn

Edit: see #2

@deitch deitch deleted the restructure-binaries branch August 15, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants