Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why using .light style? #2

Open
r-plus opened this issue Dec 28, 2020 · 1 comment
Open

Why using .light style? #2

r-plus opened this issue Dec 28, 2020 · 1 comment

Comments

@r-plus
Copy link

r-plus commented Dec 28, 2020

Hi @unboxme

First, very thanks for your work to research about _UICustomBlurEffect and iOS 14 workaround!

while using Blurberry, I found blured view is little whitey even if blur radius is 0.0 and tintColor is set to .clear

That is caused using .light style for base effect in this line https://github.com/unboxme/Blurberry/blob/0.1.0/Sources/Views/VisualEffectView+Internal.swift#L79

I try to change to simple init like this base.effect = UIBlurEffect()
then truely same color when blur radius is 0.

And, this is also for no longer need set tintColor to .clear for removing whitey purpose.

This is screenshot of before and after. (under the black border is UIVisualEffectView)

before (using .light) after (using .init())
スクリーンショット 2020-12-28 17 11 09 スクリーンショット 2020-12-28 17 10 12

Refs:
tested project: https://github.com/r-plus/BlurberryTest

@unboxme
Copy link
Owner

unboxme commented May 8, 2021

@r-plus Thank you for using my library and sorry for the late reply.

Unfortunately this solution has a one limitation — after that you couldn't set tintColor. But there's a good news, that it fixes an over-saturated blur.

I am researching this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants