Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Juno filter #209

Closed
wants to merge 1 commit into from
+42 −3
Closed

Added Juno filter #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions site/filters.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
},
{
"name": "Juno",
"is_done": false,
"is_done": true,
"usage": "juno"
},
{
Expand Down Expand Up @@ -203,4 +203,4 @@
],

"images": ["atx", "bike", "cacti", "lakegeneva", "tahoe"]
}
}
3 changes: 2 additions & 1 deletion source/scss/cssgram.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,5 @@
@import 'slumber';
@import 'brannan';
@import 'valencia';
@import 'kelvin';
@import 'kelvin';
@import 'juno';
38 changes: 38 additions & 0 deletions source/scss/juno.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
/*
* Juno
*
*/
@import 'shared';
// mixin to extend juno filter
// @mixin juno
// @param $filters... {filter} - Zero to many css filters to be added
// @example
// img {
// @include juno;
// }
// or
// img {
// @include juno(blur(2px));
// }
// or
// img {
// @include juno(blur(2px)) {
// /*...*/
// };
// }
@mixin juno($filters...) {
@extend %filter-base;
filter: contrast(1.2) saturate(0.8) $filters;
&:before {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a space between this line and the one before it and use a double :: for the pseudo element? 😄

background: linear-gradient(to bottom,rgba(255,255,255,0.2), rgba(74, 195, 111, 0.2), transparent);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Thanks for the PR! This is looking great. I don't think you need a "green" in this gradient, and might use a gray instead such as linear-gradient(top,rgba(255,255,255,.2),rgba(156, 156, 156, 0.2),transparent);

mix-blend-mode: overlay;
}

@content;
}

// juno Instagram filter
%juno,
.juno {
@include juno;
}