Fix windows support #214
Fix windows support #214
Conversation
mrginglymus
commented
Dec 19, 2024
mrginglymus
commented
- Fixes Adding windows support #212
🦋 Changeset detectedLatest commit: 5143b8a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Hmm, the attempt to remove those symlinks has gone badly... |
mrginglymus
force-pushed
the
fix-windows
branch
from
8ed4883 to
7e691d7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #214 +/- ##
==========================================
- Coverage 96.12% 96.11% -0.02%
==========================================
Files 104 105 +1
Lines 4752 4782 +30
Branches 1633 1646 +13
==========================================
+ Hits 4568 4596 +28
- Misses 179 181 +2
Partials 5 5 ☔ View full report in Codecov by Sentry. |
| errors: [ABSOLUTE_ERROR], | ||
| output: 'import f from ".."', | ||
| }), | ||
| tInvalid({ | ||
| code: `import f from "${absolutePath('/foo/bar/baz.js')}"`, |
There was a problem hiding this comment.
I don't quite understand this change, it doesn't cover Windows absolute paths.
There was a problem hiding this comment.
It's not possible to do an absolute path import on Windows - or at least, I couldn't work out how to make one.
There was a problem hiding this comment.
file:// protocol can be used for Windows absolute path, but of course we maybe not handling file:// protocol previously, same as other protocols like http:// or https://.
But in case that file:// is only for absolute local path like previous, it could be an improvement.
There was a problem hiding this comment.
Yes, using a file protocol path seems like a different question to a posix absolute path - or at least an additional feature to be added to this rule.
