Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use matrix.include to set data for optional steps #143

Merged

Conversation

marcalexiei
Copy link

I made a small improvement to the ci workflow.
Using matrix.include feature I integrate the configuration matrix with two values:

1. matrix.executeLint

It controls the execution of Lint step. The behaviour should remain the same.

2. matrix.executeCoverage

Instead of running coverage on each matrix combination I have limited it only to the node 20 combination.


Note

The main advantage is that the control value of steps execution is located near the matrix values,
so they can be updated more easily.

Tip

More information about this feature can be found on GitHub Actions documentation reference.

Copy link

changeset-bot bot commented Aug 31, 2024

⚠️ No Changeset found

Latest commit: ba1963a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codesandbox-ci bot commented Aug 31, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@marcalexiei marcalexiei force-pushed the feat/github-actions-matrix-include branch from c81210e to ba1963a Compare September 1, 2024 06:48
@marcalexiei marcalexiei requested a review from SukkaW September 1, 2024 06:50
@SukkaW SukkaW merged commit 34e1334 into un-ts:master Sep 1, 2024
21 checks passed
@marcalexiei marcalexiei deleted the feat/github-actions-matrix-include branch September 1, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants