Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export jira filter table trait #52

Closed
wants to merge 1 commit into from

Conversation

HongwuQz
Copy link
Member

need a trait to distinguish knowledge's common table and releasenote's jira filter table

Copy link

changeset-bot bot commented Nov 13, 2023

⚠️ No Changeset found

Latest commit: 55c38bb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@HongwuQz HongwuQz force-pushed the feat/export-jira-table-trait branch from 766e63b to 55c38bb Compare November 13, 2023 08:28
@@ -7,6 +7,7 @@ const CLASSNAME_MAPPER = {
'toc-macro': 'toc',
'hide-toolbar': 'expandable',
'confluence-information-macro': 'alert',
aui: 'borderless',
Copy link
Member

@JounQin JounQin Nov 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

只有 aui 的 table 才需要加吧,不要在 mapper 这儿处理,会影响其他非 table 的 aui 类,或者找到 table 才有的 class

@HongwuQz HongwuQz closed this Nov 13, 2023
@HongwuQz
Copy link
Member Author

此方案有可能会影响其他组件,拓展性不强。已更换为CSS Module方案

@JounQin JounQin deleted the feat/export-jira-table-trait branch November 13, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants