Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Integrations section to Readme #35

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Conversation

melonamin
Copy link
Contributor

I have been using these for a while and decided that it might be a good idea to share it with the community.

Utility of Raycast extension is obvious. As for the shortcut, I initially created it to use on my phone, but then quickly realized that the Services menu is a handy way to use it as well.

@umputun
Copy link
Owner

umputun commented Apr 9, 2024

I have tried the Raycast extension, but it does not work. The main issue is that the URL it returns includes the PIN appended to the correct link with \n in between.

Another minor issue is that the extension allows for the input of a longer PIN. There is an API available for the current settings (GET /params) which includes the maximum length of the PIN.

@umputun
Copy link
Owner

umputun commented Apr 9, 2024

I also tried the shortcut, but I was unable to make it work. It did not request a pin at all (perhaps it was expected to autogen it, but I am not sure). The URL it generated included this pin, which was essentially the same as the one mentioned above.

@umputun
Copy link
Owner

umputun commented Apr 9, 2024

for the shortcut i think the bug is here

image

The clipboard section should not include the pin, instead it should only be displayed in notifications.

@melonamin
Copy link
Contributor Author

the main issue is that the URL it returns includes the PIN appended to the correct link with \n in between.

Hm, this is how it looks for me:

Screenshot.2024-04-09.at.16.38.39.mp4

As expected(at least by me!) I get URL and PIN on separate lines, then I can decide if I want to share both or send only a link and pass PIN on a separate channel. Is it different for you?

Another minor issue is that the extension allows for the input of a longer PIN.

Ha, looks like I messed up a bit...

I am using the /params endpoint for auto-generated PINs, but it seems like I misplaced the form validation code. Since I never manually enter the PIN, it slipped through the cracks during my testing. This should be fixed, but will take a while, Raycast's team is quite slow.

I also tried the shortcut, but I was unable to make it work. It did not request a pin at all (perhaps it was expected to autogen it, but I am not sure).

Yes, it autogenerates, no manual input.

The clipboard section should not include the pin, instead it should only be displayed in notifications.

I'm afraid I'm not following...

I think our workflow is a bit different. Let me explain mine:

Scenario 1: I need to share an API token with my teammate, let's say it is the OpenAI Key. Here is what I do:

  • Go to the OpenAI platform and generate the key.
  • On Mac: copy the key -> run the Raycast extension with default settings. On iOS: Long press -> Share -> Run the shortcut (no additional inputs).
  • Go to Slack -> CMD+V -> Send.

I don't want the token to be in the chat history forever, but I'm okay with Safesecret link, since it is a short-lived URL.

Scenario 2: I need to share something with a security-conscious person from my customer team. Here is what I do:

  • same
  • same
  • Send the link over email and send the code on a separate channel (either text or call).

So in both cases, it makes sense to copy both the URL and PIN to the clipboard. Having the PIN only in the notification defeats the purpose...

What am I missing?

@umputun
Copy link
Owner

umputun commented Apr 9, 2024

Ok, I understand your intention now. The concept of receiving a URL and a PIN back seems a bit unusual to me, as my initial instinct was to input the result into the browser. However, for Raycast, this is something I would anticipate, since I manually entered the PIN and having it included in the response is quite unexpected. Perhaps it should not add a PIN line if the PIN was manually entered and not automatically generated?

As for the shortcut - it is likely that there is no alternative solution since the PIN is always automatically generated.

@umputun umputun merged commit c193d11 into umputun:master Apr 9, 2024
1 check failed
@melonamin
Copy link
Contributor Author

Perhaps it should not add a PIN line if the PIN was manually entered and not automatically generated?

Yes, doable. Or maybe I can offer two actions on the form submition, or two commands - one allows for PIN entry and the other one doesn't. Let me play with it, I see what works better.

As for the shortcut - it is likely that there is no alternative solution since the PIN is always automatically generated.

Here is an alternative version, it lets you choose PIN generation method and produces different result based on it. I wouldn't use it personally, but maybe useful as a second option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants