pin golangci-lint version to latest available, fix reported errors

.github/workflows/ci.yml

@@ -27,7 +27,7 @@ jobs:
     - name: golangci-lint
       uses: golangci/golangci-lint-action@v3
       with:
-        version: latest
+        version: v1.58
 
     - name: install goveralls
       run: go install github.com/mattn/goveralls@latest

.golangci.yml

@@ -1,12 +1,9 @@
 linters-settings:
   govet:
-    check-shadowing: true
-  golint:
-    min-confidence: 0.8
+    enable:
+      - shadow
   gocyclo:
     min-complexity: 15
-  maligned:
-    suggest-new: true
   dupl:
     threshold: 100
   goconst:
@@ -30,13 +27,12 @@ linters:
   disable-all: true
   enable:
     - bodyclose
-    - megacheck
     - revive
     - govet
     - unconvert
-    - megacheck
+    - staticcheck
     - unused
-    - gas
+    - gosec
     - misspell
     - unparam
     - typecheck
@@ -52,17 +48,22 @@ linters:
   fast: false
 
 run:
-  modules-download-mode: vendor
-  skip-dirs:
-    - vendor
   concurrency: 4
 
 issues:
+  exclude-dirs:
+    - vendor
   exclude-rules:
     - text: "weak cryptographic primitive"
       linters:
         - gosec
     - text: "package-comments: should have a package comment"
       linters:
         - revive
+    - linters:
+        - unparam
+        - unused
+        - revive
+      path: _test\.go$
+      text: "unused-parameter"
   exclude-use-default: false

app/server/middleware.go

@@ -52,7 +52,7 @@ func Logger(l log.L, flags ...LoggerFlag) func(http.Handler) http.Handler {
 						result = string(content)
 						r.Body = io.NopCloser(bytes.NewReader(content))
 
-						if len(result) > 0 {
+						if result != "" {
 							result = strings.Replace(result, "\n", " ", -1)
 							result = reMultWhtsp.ReplaceAllString(result, " ")
 						}